Embeddium++

Embeddium++

6M Downloads

Highly probable memory leak issue

QianFuv opened this issue · 19 comments

commented

debug.log: https://mclo.gs/M93MCBf

hs_err_pid27444.log: https://mclo.gs/gzQJIAs

latest.log: https://mclo.gs/Xs9VGzP

commented

issue appears without the mod?
and how much time takes to get out of memory?

commented
  1. No
  2. Almost 30 min

It should be noted that I did not experience this problem with Rubidium Extras.

commented

So far, no memory leaks have been found. However, I believe further testing is necessary. Please wait for my report in a few days.

commented

English is not my native language; please excuse typing errors.

I have seen your recent submission: a68be6e
Another mod in my modpack also includes this feature, and I believe that adding this feature to EmbeddiumPlus is unsafe and inappropriate.
This feature introduced by Debugify-reforged works well with fix GPU memory leak and MemoryLeakFix, and currently no memory leak issues are encountered with these three, but I don't know why there is a serious memory leak issue in EmbeddiumPlus.
All in all, this should be one of the main causes of memory leaks, the problem should be solved, thank you for your efforts!
I hope you've thought carefully when adding new features, because Embeddium is a premium mod and I want its affiliates to be as good as it is!
If there are any further issues in the future, I will continue to report them.

commented

@Qian-F
That change was reverted on build i send you. I suspect what can be the cause, when you say It no happens on Rubidium extras.

That change is pretty small and safe to implement, because Is only inject and cancel, and if any other mod do the same doesnt affect much, i can keep It without break other mods (unless i confirm my suspects of is leaking)

The major issue was caused by whitelist feature, i still dont understand why causes leak but is great know was fixed :)

Update queue for 1.0.1

commented

I may have misunderstood the cause of the problem, but all in all the problem has been solved. Thank you for your efforts!

commented

Unfortunately, the problem still exists, as soon as I add this mod to my modpack, I experience a memory leak

commented

then i have a big problem, if issue never occurs with Magnesium/Rubidium Extras but occurs with Emb++ then that means i mess up something on porting to 1.19.2

i need do more research, at the moment. i need help

commented

The most recent crash error report can be found here. I have provided feedback to the author of fix GPU memory leak because his mod did not address the issue of GL_OUT_OF_MEMORY memory leak, which is also the problem I encountered after installing Emb++.
I will test it again after waking up to make sure that this issue won't occur in Rubidium Extras.

commented

In my tests, the previous feedback needs to be modified. In my tests, both Emb++ and Rubidium Extras cause GPU memory leaks. This may be because they make the function of fix GPU memory leak mod ineffective.
I am deeply sorry for the wrong conclusion I reached earlier!

commented

try installing farsight. problem persists?

commented

I will try it later.
Please wait my feedback.

commented

One small problem is that I'm not playing on the server, just in single player, and I'm not sure that farsight will work in single player.

commented

Screenshot_2023-12-21-14-31-45-13_4d38fce200f96aeac5e860e739312e76.png

someaddon replied to me saying "does work, but it only prevents a couple bugs can't prevent all issues^^", possibly because emb++ is causing a new GPU memory leak problem? So far I am not experiencing crashes with emb++ disabled(I am playing my modpack intensively to prevent the possibility of misreporting.).

commented

I will test it today. Sorry for these two days I don't check it...

commented

I did a simple 30-minute test and everything seems normal. I'll do another hour-long test after waking up.

commented

try installing farsight. problem persists?

Crash also: https://mclo.gs/IJumAKr