Embeddium++

Embeddium++

6M Downloads

Feature request : Be able to Change Dynamic Light Strenght

AntonyCilleros opened this issue Β· 12 comments

commented

Hello
I would like to be able to change light level of held items with dynamic light because currently torches aren't powerful enough when in hands for my liking.
It's a great combo to have with True Darkness.
Lucent mod allows me to change the light level of held items but it sometimes have visual issues.

Is there a way, even an hard way, to do this currently?
Or is there a mod you would recommend to fix this?

commented

Sadly no, currently torches and others items
lights are to max capacity allowed by Minecraft. I cannot overpass Max light strengh (15).

I'll look into configure Γ­tem light strengh in range of 0~15.

And yes, exists a mod that let you have torches pass 15 limit (expanded to 32) but has bad performance and Is incompatible with Embeddium

commented

Yes I know but I dont want to go over 15.
15 is fine.
But when I am holding a torch, its strenght is clearly bellow 15 currently with embeddium++.
The only mod I found that let me set the strenght of held torches up to 15 is Lucent but as I said it sometimes have visual glitches with embeddium.

So the goal for me would be to have the torches in hand with the same strenght as a placed torch (around 14 I believe)

commented

Then that's a bug, was supposted to be Max strengh.
I'll look with more concerning, but i am pretty sure I'll make it configurable.

commented

Ok I didn't know it was a bug.
I will try to disable all my mods except embeddium++ and its dependencies.

Thanks for looking over my issue!

commented

Ok I confirm that it is not an issue from my modpack.
Screenshots bellow are with embeddium and embeddium++ only on 1.20.1

With torch in hand :
image

With torch on the ground (at my feet)
image

commented

ok i find out what's the cause.
yes, torches has max light strengh, but has a reduced range than placed torches.

Minecraft de-escalate 1 block : 1 light level in relation with the distance of the block, basically a stairs of lights
on the other hand, DynLights makes a perfect circle of brightness. making it more "lower" than placed ones.

I can make it configurable but that whould be later.

TL;DR: is not a bug, is a feature. And can be enhanced
About light keeps showing after remove torch, is a well knowed bug and onlu occurs when DynLights speed is any else than real-time

commented

Ok that explains why I had the same behavior with most of the Dynamic light mods.

Would love to be able to configure it so I can kind of buff the torches without the mod that destroy light performances. ("Brighter" is the mod's name I believe)

commented

Having at least the possibility to disable the dynamic light embedded in the mod would allow me to use Lucent as my dynamic light mod and this way I would be able to have stronger torches in hand.

commented

just a workarround, not a configurable fix.

commented

Thanks
I am gonna give it a try

commented

i close this issue just to address dynamic lights impl on the new source code
of course emb++ doesn't longer have the LDL ported impl