Embers' Construct

Embers' Construct

95.5k Downloads

Ember's Construct [Ver. 1.3.4] adds extra recipes that aren't needed, conflicting with the Embers Rekindled config

Zeitiah opened this issue ยท 3 comments

commented

After editing the Embers Rekindled config, to change the amount of ingots required to make plates (and I would assume gears as well, though I have not tested it), Ember's Construct will add back the original recipe (one ingot). This is a problem for both the dawnstone plate (which does not have a tinnker's construct recipe), and the standard modded-metals plates (which, of course, do have a TC recipe).

Embers Rekindled + Ember's Construct Config file + CraftTweaker script : https://gist.github.com/Zeitiah/8a922dedd8aebb6de54eeb1d7f1b431c

The edited Embers Rekindled recipe: 2022-04-02_00 38 48
Additional recipe added by Ember's Construct: 2022-04-02_00 38 51
The edited Embers Rekindled recipe: 2022-04-02_00 38 27
Additional recipe added by Ember's Construct. (That may be the mod just adding the recipe from Tinker's Construct): 2022-04-02_00 38 29

Note, I took these screenshots before I tried using CraftTweaker.

I cannot remove this item using CraftTweaker. Stamper.remove will only remove the recipe on jei page 1 (The two ingot recipe). Even if I run the command twice.

Maybe Ember's Construct could check if there is already a Stamper recipe for the item it's trying to add? Another suggestion is checking what recipe changes CraftTweaker has made to Tinker's Construct, and if an item has been removed/added, will either add the recipe if the former, or do nothing if the latter.

I love your mod! And thanks in advance for any help you give :)

commented

Should be fixed with commit 26bab88 and 97c621d. Now the config values get copied and I compare different recipes in a better way.

commented

Should be fixed with commit 26bab88 and 97c621d. Now the config values get copied and I compare different recipes in a better way.

Thank you!

commented

Actually I thought this was fixed. Double recipes suck honestly. But I guess modifying the original recipes somehow messes the stuff up. I will look into it.

(This is caused because I add recipes via the ore dictionary, this includes dawnstone for example. I guess my double recipe fix only checks for the exact same recipe, because that is really dumb, I guess I also have to check the fluid without amount, as soon as the fluid+stamp combo exists I have to stop)