EMI Loot

EMI Loot

9M Downloads

Some modded loot isn't showing up

aurora-1-2-3 opened this issue ยท 8 comments

commented

Items from this creator's mods (carlogamer_2) and the Arsenal mod are not appearing in the EMI menu

Yes I am EMI loot along with EMI
No I am on singleplayer

logs:
https://mclo.gs/XJSul56

commented

logs with only arsenal mod, carlo's trinkets mod and emi/emi loot
https://mclo.gs/Xbwtvuq

commented

i am assuming these are hardcoded items, right?

commented

Same problem with the End Remastered mod, the loot works fine but isn't shown in EMI

commented

mod dropped trims are also not shown from this mod https://modrinth.com/mod/more-armor-trims

commented

Usually this happens when a mod hard-codes the drops in some ways. (Neo)Forge "Global Loot Modifiers" are an example, or BcLib block drops (at least in the past)

More Armor Trims appears to be overwriting the loot table in their replace event, and not providing loot table type when doing so:
https://github.com/masik16u/More-Armor-Trims-Fabric/blob/54696f10f2c4716fd8f18102abc95d50350fcb46/src/main/java/net/masik/morearmortrims/util/ModLootTableModifiers.java#L155

This makes the Loot Table "Generic", which EMI Loot doesn't know what to do with... is it for a chest..? is it for an entity...? etc.

commented

ah, i see but is there a fix for this? or is this outright impossible

commented

For More Armor Trims, they can add the proper loot table type. For other hard coded loot, they would have to implement a loot-table-based solution for EMI Loot to be able to see it. (Both Fabric and Neo/forge have events for direct modification of loot tables without needing "hard coding")

commented

Hmmm... It seems that most of the loot EMI loots added to already existing loot tables don't show up, only when mods create a loot table themselves.

In this image, none of the loot added by Botania, Tacz, and Supplementaries shows up, but Quark's Smithing Template does, oddly enough.
Image
Image