EMI

EMI

1M Downloads

Incompatibilities with mods that modify the inventory status effect display

MerchantPug opened this issue ยท 3 comments

commented

What happened?
Within my mod Bovines and Buttercups, I noticed that my effect's icon was only rendering the base potion sprite (the lock) within the inventory screen whilst I had EMI's effect moving set to true.

Potential Solution
I'm just going to request moving the effect rendering changes outside of the mixin so others are able to modify the recreated method that you made.

With moved effects (This should show the vanilla effect that the lockdown is associated with)

image

Without moved effects

image

commented

EMI effect moving is currently definitely annoying for compat, I've been meaning to try and find a more permanent solution, moving logic outside of the mixin is technically a solution but I don't know how permanent this code is and treating it as API and suggesting people mixin to it could be troublesome, I'll try to figure out a better solution.

commented

I've made some changes to how EMI draws effects to reuse vanilla routines in slightly less standard ways, and it appears I've resolved the issue on my end. In addition, I've moved the logic into a specifically named internal method, in case other mods require more specific adjustment.
image
image

commented

Thank you