EMI

EMI

1M Downloads

GregTech tools counted too many times

steph-lion opened this issue ยท 6 comments

commented

GT tools come with a durability, as vanilla tools. The problem is, when used as a crafting material, they get counted as N, where N is the output items you want. In the screenshot: 3x hammers, 3x wire cutters.

I think it should be always considered as 1.

Example:
image

commented

This is a bug with gregtech not specifying their ingredients as having remainders.

commented

I am fairly certain we do specify the items as having remainders.

commented

right here, in fact. for all tool types.

commented

EMI has a concept for remainders on EmiStacks used in the inputs and outputs of recipes. By default, remainders are obtained for normal crafting recipes using the vanilla remainder system by assembling items in a crafting grid and calling the method, but any complex recipes or complex hooks (This seems to have access to a player during some hook?) EMI cannot provide cannot be done automatically. Your hooks do not interact with the actual recipe system so there is no way for EMI to be able to detect this.

commented

EMI has a concept for remainders on EmiStacks used in the inputs and outputs of recipes. By default, remainders are obtained for normal crafting recipes using the vanilla remainder system by assembling items in a crafting grid and calling the method, but any complex recipes or complex hooks (This seems to have access to a player during some hook?) EMI cannot provide cannot be done automatically. Your hooks do not interact with the actual recipe system so there is no way for EMI to be able to detect this.

the player hook is only used for damaging the item, it'll return the stack anyway.
anyway, how should these be registered to EMI as damageable in some way?

commented

In a recipe, remainders are defined using EmiStack.setRemainder