Emojiful

Emojiful

19M Downloads

Conflicts with styledchat

FederAndInk opened this issue ยท 9 comments

commented

:) is being transformed into :slightly_smiling_face: that is interpreted as markdown by styledchat (it puts smiling in italic). However, it works with :( spawning the emoji and is not modified by styledchat:

Screenshot_20230131_010756

Screenshot_20230131_010749

  • fabric with MC 1.19.2
  • emojiful 4.0.4
  • styled chat 2.0.2
commented

I'm not sure what emojiful can even do in this context, because from what I can see, Styled Chat is unconditionally and always adding the italic style to all substrings that have _ in between, as well as stripping the characters from the message.

I haven't debugged it extensively, but I cannot see any option for StyledChat to disable italic checking...

commented

Thanks for the answer, what's weird though is that it's working with :( or :D it correctly inserts the emoji and isn't transformed by styled chat

commented

Yes? Why would you expect that to transform the emoji by styled chat?
Styled Chat replaces _hello_ with hello, like Github or Markdown formatting does. The problem is that it does that before Emojiful sees the emoji, so whenever Emoji sees the message it has been turned into: :slightly(smiling)face: where smiling is in italic.

commented

I mean, this is not working (see the preview of styled chat above and what I typed under):
Screenshot_20230131_123805

and this is working:
Screenshot_20230131_123906

in both cases I used :) or :( but the former is parsed by styled chat and the later not

commented

ok sorry, I thought :( was :slightly_frowning_face:

commented

That happens because the top one has a substring surrounded by _, which causes StyledChat to replace it with italic.

commented

ok sorry, I thought :( was :slightly_frowning_face:

I know markdown rules ^^
just didn't realized :( wasn't :slightly_frowning_face:

commented

Btw, this was fixed a while ago, feel free to close

commented

Thanks for letting me know