Emojiful

Emojiful

19M Downloads

HexGloop text rendering incompatability

SamsTheNerd opened this issue ยท 0 comments

commented

howdy ! I have a mod called HexGloop that changes the text rendering to be able to render Hex Casting's patterns and it seems to break when Emojiful is installed.

Gloop has a few main mixins:

  1. Style parsing and injecting https://github.com/SamsTheNerd/HexGloop/blob/main/common/src/main/java/com/samsthenerd/hexgloop/mixins/textpatterns/MixinParsePatternFormatting.java & https://github.com/SamsTheNerd/HexGloop/blob/main/common/src/main/java/com/samsthenerd/hexgloop/mixins/textpatterns/MixinPatternStyle.java
    As far as I can tell emojiful doesn't effect these? Could be wrong though

  2. TextRenderer$Drawer's accept (or for your mapping Font$StringRenderOutput's) handles most of the rendering https://github.com/SamsTheNerd/HexGloop/blob/main/common/src/main/java/com/samsthenerd/hexgloop/mixins/textpatterns/MixinTextDrawerPatSty.java

  3. Injecting into TextRenderer/Fonts constructor to change the character widths to match https://github.com/SamsTheNerd/HexGloop/blob/main/common/src/main/java/com/samsthenerd/hexgloop/mixins/textpatterns/MixinPatTextWiden.java

It looks like EmojiFontRenderer$EmojiCharacterRenderer.accept() just uses a copy paste of the code from Font$StringRenderOutput.accept() for everything in the first else block ? Having it just call the code directly would probably fix the issue with my accept mixin

I think all the other mixins should work fine ? but wanted to list them incase you see anything that'd break.