PacketEvents/GrimAC compat
ManInMyVan opened this issue · 4 comments
Describe the bug
GrimAC use PacketEvents to listen to packets, it has a hardcoded limit of 32767 bytes for payload packets. This mod sends payload packets larger than this, which causes exceptions. If you are sending a file with packets, I recommend replicating what minecraft does for resource packs.
To Reproduce
start a 1.21.5 paper server with emotecraft and grim
join with a 1.21.5 fabric client with emotecraft
try to start an animation
Expected behavior
no exception
Minecraft version+mod loader
1.21.5 Fabric client using emotecraft-fabric-for-MC1.21.5-2.6.1.jar
1.21.5 Paper server using emotecraft-paper-for-MC1.21.5-2.6.1.jar
Mod version: 2.6.1
Minecraft log and crash report:
https://mclo.gs/7QoJXXR
Additional context
A user reported this in grim's discord (see https://discord.com/channels/811396969670901800/1384909944012406816)
Btw, judging by the log, this doesn’t affect Emotecraft functionality, right? Let me know if it does, and I’ll try to hack PacketEvents so it can’t handle packets larger than 32kb.
That's because paper crap
Minecraft allows you to send up to 8mb in a single packet
Unfortunately the 32kb limit is too small for emotes, if we can't send 1mb or more in the future on paper, its support will be discontinued
Btw, judging by the log, this doesn’t affect Emotecraft functionality, right? Let me know if it does, and I’ll try to hack PacketEvents so it can’t handle packets larger than 32kb.
they didn't say anything about being kicked, you'd have to ask depricson or test it yourself, but if you do try to hack PacketEvents, know that many plugins (particularly anticheats and antiexploit plugins) shade (and sometimes obfuscate) packetevents and get their own instance of it.