Enchancement

Enchancement

Mods
596k Downloads

Invalidation of `RegistryEntry.Reference` leads to issues with mods expecting Enchantments to be found within Registry

Dragon-Seeker opened this issue ยท 1 comments

commented

Confirmations

  • I can verify that I am running the mod on the latest possible Minecraft version.
  • I can verify that the issue I am reporting exists on the latest possible Mod version.

Mod version (NOT Minecraft version)

enchancement-1.21.4-r2

A description of the issue

As discussed with an issue reported on Accessories for a crash related to looting adjustment code with it seems that enchancement invalidates RegistryEntry.Reference with unregistrerd Enchantment that will then not be found with the registry leading to crashing if people expect such.

Log or crash report

https://mclo.gs/HkKI1q8

commented

Thank you for the report! I have already fixed this on my end (at least specifically the optional on getEntry returning empty; I have a specific empty / no-op enchantment that I return in most cases but I must have missed this one