Enchanting Infuser [Forge & Fabric]

Enchanting Infuser [Forge & Fabric]

3M Downloads

[Bug]: Compatibility with No-Enchant-Cap Mod

Wubzzz1337 opened this issue ยท 4 comments

commented

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

v4.2.2

Notes (Required)

Not working with No Enchant Cap settings.

Would be cool if this could work together and follow each other rules etc.
Other Mod: https://www.curseforge.com/minecraft/mc-mods/no-enchant-cap
Also Opened Issue there: AmyMialeeMods/no-enchant-cap#24

latest.log (Optional)

No response

commented

I'm assuming you mainly refer to the mix_any_enchants and enchant_any_item features from that mod?
From quickly glancing at their code those options are hardcoded to only work for anvils and have nothing to do with enchanting tables.

But I also won't be adding support, I don't really see the point in those features: Enchantment behavior for the most part is hardcoded in Minecraft's code, even when you put enchantments on items they normally can't be put on in like 90% of cases the enchantments just won't work. I don't feel a need to support something like that.
If Amy wants to add support though and wants a custom api hook or something like that I'd be open to add that though.

commented

If you're genuinely interested in properly supporting certain enchantments on more items and customizing allowed enchantment combinations, I'd recommend taking a look at another mod of mine: https://www.curseforge.com/minecraft/mc-mods/universal-enchants-forge
It selectively enables certain enchantments on more items where they actually make sense, makes sure those enchantments properly work on the new items, and does all that in a way that generally works out of the box with other mods (like Enchanting Infuser).

commented

The only issue with the "Universal Enchants" is that you have to add manually the new Enchantments instead of having just an "allow everything" etc thing. Otherwise I would be using that mod.

commented

Yea honestly enchant_any_item is only really useful for silly things like fire aspect sticks or what have you, but 90% of enchants don't do anything so it's not actually that useful. You'd be much better off just using universal enchants.