Enchanting Infuser [Forge & Fabric]

Enchanting Infuser [Forge & Fabric]

3M Downloads

[Bug]: Bookshelves not increasing infuser power (1.20.4)

Gamemassa opened this issue · 11 comments

commented

Mod Loader (Required)

Fabric

Minecraft Version(s) (Required)

1.20.4

Mod Version(s) (Required)

20.4.0

Other Mods Involved (Required)

No

Notes (Required)

I put bookshelves around an infuser (tried with both the normal one and the advanced one, and the enchanting power never changed from "0/3" no matter how many bookshelves I placed.

latest.log (Required)

https://gist.github.com/Gamemassa/97e3b3929b0fd444d1683d2adfa10b6d

commented

Please send a screenshot with F3 looking at the shelves so I can see the block id.

commented

What bookshelves?

commented

What bookshelves?

The vanilla ones.

commented

Please send a screenshot with F3 looking at the shelves so I can see the block id.

Here is a screenshot of me looking at the vanilla bookshelf with F3 open, as requested. I have also tried dozens of modded bookshelves, but I think if I put screenshots of all of them in here it will overflow the thread, so I'll just try to write down all the block ids.
2024-03-08_09 38 56

commented

What bookshelves?

Hi, not sure if you've been able to look at this (and I promise I'm not trying to rush you), but I wanted to let you know I was able to reproduce the bug in a different instance of Minecraft with only Enchanting Infuser (and its prerequisites). In this screenshot, you can see I have 5 bookshelves around this Advanced Infuser:

image

But when I right-click the infuser, it still thinks I have zero bookshelves around it (highlighted):
image

commented
commented

(Facepalm)

commented

What bookshelves?

Update to this issue: modded bookshelves from BetterEnd and BetterNether are not increasing the power of the Infuser (though they are increasing the power of vanilla enchanting tables). Here is a list of all the block IDs:

betterend:mossy_glowshroom_bookshelf
betterend:pythadendron_bookshelf
betterend:end_lotus__bookshelf
betterend:lacugrove_bookshelf
betterend:dragon_tree_bookshelf
betterend:tenanea_bookshelf
betterend:helix_tree_bookshelf
betterend:umbrella_tree_bookshelf
betterend:jellyshroom_bookshelf
betterend:lucernia_bookshelf

betternether:nether_reed_bookshelf
betternether:stalagnate_bookshelf
betternether:willow_bookshelf
betternether:wart_bookshelf
betternether:warped_bookshelf
betternether:crimson_bookshelf
betternether:rubeus_bookshelf
betternether:mushroom_fir_bookshelf
betternether:nether_mushroom_bookshelf
betternether:anchor_tree_bookshelf
betternether:nether_sakura_bookshelf

Also, bookshelves from the Iron Bookshelves mod, which are supposed to be stronger than normal bookshelves, are increasing the power of the infusers, but only by one unit instead of their intended amounts. Here is a list of their block IDs (along with their intended power levels):

ironbookshelves:copper_bookshelf - 1.5
ironbookshelves:iron_bookshelf - 2
ironbookshelves:amethyst_bookshelf - 2.5
ironbookshelves:steel_bookshelf - 3
ironbookshelves:golden_bookshelf - 3
ironbookshelves:bronze_bookshelf - 4
ironbookshelves:diamond_bookshelf - 5
ironbookshelves:emerald_bookshelf - 6
ironbookshelves:obsidian_bookshelf - 7
ironbookshelves:crying_obsidian_bookshelf - 8
ironbookshelves:netherite_bookshelf - 10
ironbookshelves:enderite_bookshelf - 12

Footnote: I also anticipate that when MehVahdJandukaar updates his EveryCompat mod for 1.20.4, I might have to add a whole bunch more bookshelf block IDs to this list (but that's way down the road because several other mods need to be updated before that can happen).

commented

Vanilla has a block tag for defining enchanting power providers. Enchanting Infuser uses that tag. If mod authors don‘t add their bookshelves to that they will not work.

commented

Vanilla has a block tag for defining enchanting power providers. Enchanting Infuser uses that tag. If mod authors don‘t add their bookshelves to that they will not work.

Aha! Thanks so much for explaining. I'll pass this along to the BCLib team and the Iron Bookshelves team and see what they say.

commented

Vanilla has a block tag for defining enchanting power providers. Enchanting Infuser uses that tag. If mod authors don‘t add their bookshelves to that they will not work.

Hey Fuzs, just in case the BCLib and Iron Bookshelves devs aren't able to do anything from their end (or don't want to, which is totally fair), am I able to add the modded bookshelves to the proper tag myself via datapack? And if so, do you happen to know offhand what the tag is?

Edit: I fixed the issue with the BetterEnd and BetterNether bookshelves with datapacks, but I suspect there's some other kind of issue at play with Iron Bookshelves, so I posted it in their GitHub issues tab.