Non-Fatal Crash with some modded items
brisingraerowing opened this issue ยท 2 comments
Trying the 1.12.2 alpha v5.0.156 (from the MCModDev Maven) and this happened when I put a Supremium helmet into the table. It also duped the helmet. (I have VanillaFix, which is what alerted me to the crash).
I noticed the code has changed, and from the diff I think enchantment.type was null for some reason (probably a mod not registering something correctly).
I just checked the MC source, and enchantment.type is Nullable. So there needs to be a null check for that.
It's weird that this would be an issue, since vanilla (or a forge patch) is doing the same code without a null check on this. I've made a change which uses the existing code, which should solve this. I am planning to revise this code in the future so if it still has issues let me know.