[1.10.2] Client Crash trying to generating world

Question

[1.10.2] Client Crash trying to generating world

Morpheus1101 opened this issue 7 years ago · 9 comments

Morpheus1101 commented 7 years ago

Yesterday17 · Answer 1 · 2017-11-11T19:12:50.000Z

@Morpheus1101
Since this mod doesn't have a open source license, it's all right rights reserved by default(see github's tos). But i don't whether it's permitted to share this built version of Enchanting Plus. So if there's any problem, @Darkhax please tell me and i'll remove it.

Dropbox

Darkhax · Answer 2 · 2017-11-11T19:18:41.000Z

I have no issue with you sharing this particular version here. Just don't include it in any publicly distributed mod packs, or pass it off as an official or supported version.

Morpheus1101 · Answer 3 · 2017-11-11T21:45:18.000Z

Its ok i just removed E+ from the public pack .. it was only 1.10.2 and the last update to the pack and im actively developing a 1.12.2 pack now. thanks anyway

Darkhax · Answer 4 · 2017-06-09T15:50:52.000Z

Caused by: java.lang.NullPointerException
	at net.darkhax.eplus.item.ItemScroll.enchantScroll(ItemScroll.java:58) ~[ItemScroll.class:?]
	at net.darkhax.eplus.item.ItemScroll.createScroll(ItemScroll.java:47) ~[ItemScroll.class:?]
	at net.darkhax.eplus.item.ItemScroll.func_150895_a(ItemScroll.java:119) ~[ItemScroll.class:?]
	at crazypants.enderio.integration.jei.ItemHelper.getValidItems(ItemHelper.java:24) ~[ItemHelper.class:?]
	at crazypants.enderio.integration.jei.DarkSteelUpgradeRecipeCategory.<clinit>(DarkSteelUpgradeRecipeCategory.java:67) ~[DarkSteelUpgradeRecipeCategory.class:?]
	... 41 more

Morpheus1101 · Answer 5 · 2017-06-10T08:27:31.000Z

https://github.com/Darkhax-Minecraft/Enchanting-Plus/blob/master/src/main/java/net/darkhax/eplus/item/ItemScroll.java#L58

enchantment.getRegistryName() can be null

i could be wrong but....well yeah

Darkhax · Answer 6 · 2017-06-10T17:05:16.000Z

It shouldn't ever be null. Enchantments with null registry names are still adding enchantments the 1.7.10 way and need to fix it. Looking through the code, that doesn't seem to be the specific issue here though.

Morpheus1101 · Answer 7 · 2017-08-11T02:42:52.000Z

Was the problematic mod every found with this issue or was it E+ and being 1.10.2 is no longer being supported?

Darkhax · Answer 8 · 2017-08-11T03:33:44.000Z

Unfortunately not. The code for 1.12 had many built in checks to detect and identify these, without causing crashes.

Morpheus1101 · Answer 9 · 2017-08-11T04:13:45.000Z

This was something i re-occured using 1.10.2 which as a side note also cause JEI to stop functioning .. While i did not do extensive tests, by disabling E+ this resolved the issue of JEI not working in SP & SMP but also allowed a SP World to be loaded. But also being 1.10.2 i wasnt sure if the version is still supported

Share to