Enchantment Descriptions

Enchantment Descriptions

Mods
149M Downloads

[CRASH] 1.21.1 crash when viewing item with an enchantment from another mod that I assume doesn't have a defined description.

Temil2006 opened this issue ยท 1 comments

commented

Minecraft Version

1.21.1

Mod Version

21.1.5

Mod Loader

Forge

What environment are you running the mod in?

Client

Issue Description

anytime when you hover over an item that I can only assume doesn't have a description for the mods enchantment, it crashes the client because it can't find the description as null.

easiest way to found to see this happening is to enable the requirement to hold SHIFT to see the description, then place the original item (without the problem) into the anvil, the enchantment book into there, and hover over the resulting item. you will see that the resulting item will have different spacing when not holding shift. if you press shift on the original item, it will "hide" the space under the enchantment name. but if you hover over the resulting item, you will see there is no space there.. instead when you press SHIFT over the resulting item, it will crash the client.. because it's trying to go in reverse for the item description. (kind of hard to explain. hope that makes sense? .. I can send a video if needed).

screenshot of hovering over original item (not holding shift)
image

screenshot of hover over resulting item (not holding shift)
image

Yield 3 is from the "Infinate Caves" mod, but this happens with multiple mods that add enchantments, again I can only assume the other mod auther never set a description for the enchantment, so it's breaking yours. feel like it's there issue, but asking them to set descriptions for multiple mods to work around yours isn't really doable or as easier as asking you to take this "blank descriptions" into account.

Again, just a theory as i can't find any description for any of there enchantments anywere, so assume that's the issue.

Crash Log

crash_export.txt

Are you doing anything weird?

No response

commented

Hello, the crash log shows that the crash is coming from better combat. It looks like someone is adding a null tooltip entry. That would line up with your theory that the missing description is causing this, however I already account for that in the code. I will take a closer look at this in a bit.