End Portal Recipe (Fabric)

End Portal Recipe (Fabric)

35.8k Downloads

Current Game Music Track just showing current biome

Dannyxv8 opened this issue · 1 comments

commented

Information

Minecraft version: 1.20.1
Modloader: Forge
Forge version: 47.2.6
Environment: Singleplayer

Mod name: Current Game Music Track
Mod version: 1.1

Description

Just wanted to say I really appreciate you creating a mod like this!! I've been wanting a mod like this for ages as I can never remember what the names are of my favorite tracks so thank you!

But as of now, the name popup is only currently showing the biome I'm in instead of the song's name when a song plays. I wasn't able to take a screenshot but "Danny" started playing and it just displayed "Cherry Grove".

commented

I'm gonna up this... :p

It just show the "main categorie" of the sound.json list

	"music.end": {
		"replace": true,
		"sounds": [
			{ anything played here will diplay "♪end♪" ingame

I have an idea to display custom songs tho.
Assuming they are correctly defined throu the sound.json and not just replaced ogg files.
From the wiki "subtitle" is an argument you can use, but also apply for the general music.something
We could use it to set the track name the mod would display (having the ogg file would not be great as it can't have spaces or caps.
Example:

"sounds": [
			{
				"name": "custom/pack_perso/game_music/end/lotr/amon_hen",
				"stream": true,
				"volume": 0.4,
				"weight": 15,
				"subtitle": "Amon Hen"
			},
.......
]
  • I have tested, it won't break the ressource pack used like in my example anyway. (but it does not display as vanilla subtitle)