[1.12.2] Conduit Replace Dupe / Config Option

Question

[1.12.2] Conduit Replace Dupe / Config Option

yepidoodles opened this issue 7 years ago · 5 comments

yepidoodles commented 7 years ago

Issue Description:

Conduit replace dupes the conduit being placed

This dupe only happens on the server (it is also SpongeForge, not able to test on normal forge). I know that many mod developers do not support SpongeForge, so if you are not able or willing to fix this, I only ask for a config option to disable the replace.

What happens:

https://i.gyazo.com/eafe88a3bee2ff89ba3edc3127b13294.mp4

What you expected to happen:

One is replaced with the other, and that one is used.

Steps to reproduce:

See GIF

Affected Versions (Do not use "latest"):

EnderIO: 5.0.29
EnderCore: 0.5.35
Minecraft: 1.12.2
Forge: 14.23.4.2708
SpongeForge: 3291

Your most recent log file where the issue was present:

N/A

Many thanks for your time,

~ Alice

HenryLoenwind · Answer 1 · 2018-07-12T20:20:06.000Z

Dupe. Caused by sponge.

…

Sent from my iPhone

On 12. Jul 2018, at 22:02, yepidoodles ***@***.***> wrote: Warning: This message has had one or more attachments removed Warning: (msg-10638-11.html). Warning: Please read the "j-e-b-Attachment-Warning.txt" attachment(s) for more information. #### Issue Description: Conduit replace dupes the conduit being placed This dupe only happens on the server (it is also SpongeForge, not able to test on normal forge). I know that many mod developers do not support SpongeForge, so if you are not able or willing to fix this, I only ask for a config option to disable the replace. #### What happens: https://i.gyazo.com/eafe88a3bee2ff89ba3edc3127b13294.mp4 #### What you expected to happen: One is replaced with the other, and that one is used. #### Steps to reproduce: See GIF ____ #### Affected Versions (Do *not* use "latest"): - EnderIO: 5.0.29 - EnderCore: 0.5.35 - Minecraft: 1.12.2 - Forge: 14.23.4.2708 - SpongeForge: 3291 #### Your most recent log file where the issue was present: N/A Many thanks for your time, ~ Alice -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #4766 This is a message from the MailScanner E-Mail Virus Protection Service ---------------------------------------------------------------------- The original e-mail message contained potentially dangerous content, which has been removed for your safety. The content is dangerous as it is often used to spread viruses or to gain personal or confidential information from you, such as passwords or credit card numbers. Due to limitations placed on us by the Regulation of Investigatory Powers Act 2000, we were unable to keep a copy of the original attachment. The content filters found this: MailScanner: Found a script in HTML message -- Postmaster MailScanner thanks transtec Computers for their support

bloodmc · Answer 2 · 2018-07-21T00:41:46.000Z

@HenryLoenwind You seem to be returning a result of EnumActionResult.FAIL here
https://github.com/SleepyTrousers/EnderIO/blob/master/enderio-conduits/src/main/java/crazypants/enderio/conduits/conduit/AbstractItemConduit.java#L157

Sponge relies on this result being returned properly. If a result of FAIL is returned, Sponge will restore the item to its previous state. You should be returning EnumActionResult.TRUE when this method is successful.

HenryLoenwind · Answer 3 · 2018-07-21T11:50:35.000Z

Sponge will restore the item to its previous state---so, you're doing things differently than Forge.

This is onItemUseFirst(), so: PASS=pass on to the next item, FAIL=end processing here, SUCCESS=end processing here+swing arm+reset animations. So, while there's no reason we don't want the arm swing in this case, our usage of FAIL is correct.

bloodmc · Answer 4 · 2018-07-21T14:35:04.000Z

Regardless of animations on client, a result of FAIL has always meant there were no changes made. There are no cases, that I can find, where vanilla is making changes on item use and returning a result of FAIL just to avoid client-side animations. And yes I know this is onItemUseFirst but Forge copied this from onItemUse so the results should be treated the same.

https://github.com/SleepyTrousers/EnderIO/blob/master/enderio-conduits/src/main/java/crazypants/enderio/conduits/conduit/AbstractItemConduit.java#L141-L157

This is only running on server side so a result of FAIL has no affect on client-side animations.
On client you swing arm and return PASS.

tterrag1098 · Answer 5 · 2018-07-21T14:56:21.000Z

Let's not argue semantics when this is clearly a bug on our end. You can see it was added accidentally here: e67a982