Ender IO Forestry

Ender IO Forestry

955k Downloads

ItemHelper.getValidItems() is a bit slow

mezz opened this issue ยท 0 comments

commented

I'm profiling JEI load times on a stupidly large pack (ATM3) and I found EnderIO's ItemHelper.getValidItems() is a bit slow.

https://github.com/SleepyTrousers/EnderIO/blob/a9f0ca7aa126ec3852309b6893dbecb7cf84b8fa/enderio-base/src/main/java/crazypants/enderio/base/integration/jei/ItemHelper.java#L44-L55

You may want to cache it or call mezz.jei.api.ingredients.IIngredientRegistry#getAllIngredients() to get basically the same list that's already built by JEI.