Pointing a Better Builder's wand at a capacitor bank causes a crash to desktop
BinaryConstruct opened this issue · 5 comments
Issue Description:
In the modpad FTB Sky Odyssey, pointing a Better Builder's wand at a capacitor bank causes a crash to desktop. This has been reported to FTB and is a cross post of FTBTeam/FTB-Sky-Odyssey#353
What happens:
Pointing a Better Builder's wand at a capacitor bank causes a crash to desktop
What you expected to happen:
Render the building squares for wand, no CTD.
Steps to reproduce:
- Create new creative world.
- Place vibrant capacitor bank, point better builder's wand at bank.
Affected Versions (Do not use "latest"):
- EnderIO-1.12.2-5.0.43
- EnderCore-1.12.2-0.5.53
- Minecraft: 1.12.2
- Forge: forge-1.12.2-14.23.5.2815
- SpongeForge? no
- Optifine? no
- Single Player and/or Server? SP
Your most recent log file where the issue was present:
I'm pretty sure it's a bug in Ender IO, it seems to drop an ItemEntity with an empty ItemStack in it, perhaps only on client side. Possible fix is, don't drop item on client side, it will be sent from server. There was an issue recently with Botania magnets too, while botania fixed it on their end by adding !isEmpty() check, it's still EIO issue
Ender IO isn't dropping an empty EntityItem, Builder's Wand is creating an empty ItemStack for our item. Which is a logic error as that stack is completely useless.
new ItemStack(whatever, 0, 0)
PS: Read the Botania patch again...: VazkiiMods/Botania@1701732