Ender IO Forestry

Ender IO Forestry

954k Downloads

Dark Shears activate tripwire hooks when used to break string

TopPercentageRattata opened this issue ยท 5 comments

commented

Issue Description:

Dark shears don't have vanilla shears tripwire breaking feature

What happens:

Breaking tripwire(string) with dark shears activates tripwire hooks

What you expected to happen:

Tripwire hooks should not activate when the string is broken by shears

Steps to reproduce:

  1. Place tripwire hooks and string
  2. Break the string with dark shears
  3. Watch tripwire hooks activate

Affected Versions (Do not use "latest"):

  • EnderIO: 5.0.43
  • EnderCore: 0.5.57
  • Minecraft: 1.12.2
  • Forge: 14.23.5.2836
  • SpongeForge? No
  • Optifine? No
  • Single Player and/or Server? SP

Your most recent log file where the issue was present:

Probably not needed for this

commented

Vanilla logic not enderio

commented

Still a bug

commented

image
This is the vanilla code ^

Feel free to report it to Mojang...

commented

ugh, even in 1,13 it's a hardcoded == check and not a tag.

commented

Yes, vanilla code is really annoying that way. There's just so much item identity checks everywhere. Forge replaces a good number with isXXX() calls on the item, but not all.

I'll have a look if we can "manually" disarm the trip wire when the shears are used, but as this is in block breaking code I'm not too optimistic. Items have good control for handling of right-clicking, but not so much on left-clicking.