Right clicking on item conduit with another "pops" it off
Opened this issue ยท 7 comments
Issue Description:
When i right click on an item conduit with an item conduit in my hand, it just gives me another item conduit that has some NBT data on it.
What happens:
When i right click on an item conduit with an item conduit in my hand, it just gives me another item conduit that has some NBT data on it.
What you expected to happen:
I expect to just place another conduit down.
Steps to reproduce:
- Place an item conduit
- Be holding another item conduit
- Right click on the item conduit
...
Affected Versions (Do not use "latest"):
- EnderIO: 5.0.4.4
- EnderCore: 0.5.57
- Minecraft: 1.12.2
- Forge: 1.12.2 v2815
- SpongeForge? No
- Optifine? Yes
- Single Player
Your most recent log file where the issue was present:
YT video:
https://youtu.be/QRL9Y1857zI
Edit: You can see the item conduit popping the the hotbar that don't stack with the original.
[pastebin/gist/etc link here]
Looks like the conduit upgrade code works on item conduits?
https://github.com/SleepyTrousers/EnderIO/blob/22717941f4313ccce6faa68ac386cd2abc9d2718/enderio-conduits/src/main/java/crazypants/enderio/conduits/conduit/AbstractItemConduit.java#L119-L163
Edit: yeah.. whats the NBT data on those conduits?
Edit 2: Unable to reproduce with just Enderio installed
The issue is that "some NBT data". That should not be there and it tells our code "hey that conduit in the player's hand is not the same as the one in the bundle".
Yes, tyler, your analysis was point on. Line 140 above is where our code gets thrown off.
This is the NBT data for the item conduit that didn't stack:
https://imgur.com/a/fQJlUvw
Also, when i break a regular item conduit it also turns into the weirded out conduit.