Ender IO Forestry

Ender IO Forestry

Mods
954k Downloads

Upgrading some machines results in losing the energy and capacitor inside.

YuRaNnNzZZ opened this issue ยท 0 comments

commented

Issue Description:

When i upgrade Wired Charger to Enhanced Wired Charger, the capacitor gets lost because the recipe is not marked as upgrading one.
https://github.com/SleepyTrousers/EnderIO/blob/1e6b68a3df264827b6a93416d6dc63f43b65597d/enderio-machines/src/main/resources/assets/enderio/config/recipes/machines.xml#L182-L183
https://github.com/SleepyTrousers/EnderIO/blob/1e6b68a3df264827b6a93416d6dc63f43b65597d/enderio-machines/src/main/resources/assets/enderio/config/recipes/machines.xml#L215-L216
https://github.com/SleepyTrousers/EnderIO/blob/1e6b68a3df264827b6a93416d6dc63f43b65597d/enderio-machines/src/main/resources/assets/enderio/config/recipes/machines.xml#L237-L238
https://github.com/SleepyTrousers/EnderIO/blob/1e6b68a3df264827b6a93416d6dc63f43b65597d/enderio-machines/src/main/resources/assets/enderio/config/recipes/machines.xml#L248-L249

What happens:

The machine loses all its data after upgrade.

What you expected to happen:

The upgraded machine should retain capacitor and stored energy.

Steps to reproduce:

  1. Craft Wired Charger
  2. Place any capacitor in it
  3. Break the machine
  4. Upgrade it to Enhanced Wired Charger
  5. Notice that crafting result doesn't have any NBT data on it.

Affected Versions (Do not use "latest"):

  • EnderIO: 1.12.2-5.0.49 (up to the latest Git revision)
  • EnderCore: 1.12.2-0.5.65
  • Minecraft: 1.12.2
  • Forge: 14.23.5.2838
  • SpongeForge: no
  • Optifine: no
  • Affects both SP and MP

Your most recent log file where the issue was present:

Non-crash issue