Ender IO Forestry

Ender IO Forestry

954k Downloads

Refined Storage Conduit - Importing from network sluggish

MaximumPotato opened this issue ยท 3 comments

commented

Issue Description:

Using Refined Storage Conduits to pull items from a refined storage network into an external inventory can result in the conduit jamming up if there is no space in the external inventory for any one of the whitelisted items, despite there being space for the others.

What happens:

When connecting Refined Storage machines to an external inventory via Refined Storage Conduits, and setting an import filter on the external inventory to pull from the network, items appear to be pulled from the Refined Storage Network in a rotating First In, First Out manner. This means that if there is no space in the external inventory for item A, but there is space for item B, C, etc... the cable will get stuck when it next tries to pull item A into the inventory. As a result the free space for the rest of the items will not fill up.

Video Example comparing current behavior to desired behavior:
https://streamable.com/yvxyf

What you expected to happen:

Mimic the behavior of the regular Item Conduits in EnderIO. Any free space in a destination inventory should be filled so long as there are items available to fill it.

Steps to reproduce:

  1. Place a Refined Storage Controller, Storage Block and Grid.
  2. Add 9 stacks each of Orange, Magenta and Cyan wool. (For easier visualization)
  3. Place single chest.
  4. Fill the chest with 9 stacks each of Orange, Magenta, and Cyan wool. (Again for easier visualization)
  5. Connect the chest to the Refined Storage machines via Refined Storage Conduits.
  6. On the conduit connected to the Refined Storage Machines, leave all settings as default.
  7. On the conduit connected to the external inventory, add a basic filter. (Any filter will share the same behavior)
  8. Add one piece the orange, magenta, and cyan wools to the filter.
  9. Open the external inventory and play with removing half a stack of different color wools. The problem should become apparent.

Affected Versions (Do not use "latest"):

  • EnderIO: EnderIO-1.12.2-5.0.50.jar
  • EnderCore: EnderCore-1.12.2-0.5.65.jar
  • Minecraft: 1.12.2
  • Forge: forge-14.23.5.2838
  • SpongeForge? no?
  • Optifine?: no
  • Single Player and/or Server?: server

Your most recent log file where the issue was present:

I can't figure out where this is located.

commented

one or more of #5223, #5073, #4904, #5053

commented

While those may be related on the back end none of those issues cover what I've mentioned here.

commented

In any case I have tested with the rewrite done in f4cdbdb and it seems to have fixed the issue.