Ender IO

Ender IO

Mods
98M Downloads

Conduit Probe does not copy "Round Robin" or "Self Feed" settings

Closed this issue ยท 3 comments

commented

Is there an existing issue for this?

  • I did not find any existing issues.

Current Behavior

When using the Conduit Probe to copy/paste Item Conduit settings, the "Round Robin" or "Self Feed" settings are not copied over as well.

Expected Behavior

Conduit Probe copy/paste mode should copy over all conduit settings.

How to Test

  1. Create a new world.

  2. Set up two pairs of Item Conduits connected to Chests.

Image

  1. Set one conduit to have both "Round Robin" or "Self Feed" enabled.

Image

  1. Use the Conduit Probe in Copy/Paste mode to copy the settings over to the other conduit.

  2. Nothing changes.

Image

Local Environment

- **Operating System**: Windows 10
- **Java version**: Oracle JDK-17.0.12
- **Minecraft Version**: 1.20.1 
- **Version**: 6.2.11-beta
- **Other Mods**: EMI and JEI

Any Additional Information?

No response

commented

I regret to say that we no longer officially support Minecraft 1.20.1 - as such we will not be officially fixing this issue.

If any community member wishes to submit a pull request to address this issue, feel free to open a PR and we will review and merge it.

I will close outstanding 1.20.1 issues in a little while, to keep the issue list clear.

Thanks again for your report.

commented

Round-robin and self-feed are currently not saved in conduit probe settings because they're saved in ItemConduitData as item conduit-specific parameters instead of DynamicConnectionState, where all the other conduit settings are.

I would like to work on this issue, but seeing that @Rover656 mentioned that priority and round robin (and probably self-feed?) should stay in ItemConduitData, maybe I shouldn't refactor DynamicConnectionState and instead grab data directly from ItemConduitData through bundle.getNodeFor()?

commented

Fixed by #1124