Ender IO

Ender IO

Mods
92M Downloads

Upgrading Energy Conduit stops transmitting power

Rover656 opened this issue ยท 2 comments

commented

Needs investigation, reported via Monifactory survey

commented

i've never done minecraft modding so I don't really know how to test this, but from a quick glance of the code:

EnderIO/enderio-conduits/src/main/java/com/enderio/conduits/common/conduit/block/ConduitBundleBlockEntity.java

Lines 331 to 333 in ca127c7

if (action instanceof RightClickAction.Upgrade upgrade && !upgrade.replacedConduit().value().canConnectTo(conduit)) {
removeNeighborConnections(upgrade.replacedConduit());
}

upgrade.replacedConduit() returns the old conduit, that was upgraded. So this check always returns true when an energy conduit is upgraded.

therefore removeNeighborConnections() is getting called every time an energy conduit is upgraded.

I think logically, an easier way to handle upgrades would just be to treat it the same as a break then a placement.

commented

I did some tests and as Y3RmKHgp said and seems like when upgrading any conduit it changes its connections. For energy conduits, the extract seems to remain after the upgrade, but the insert doesn't. And for fluids, both needed to be re-toggled.
https://youtu.be/hsEU6EoMbuA