Ender Storage 1.8.+

Ender Storage 1.8.+

99M Downloads

Deprecated version of getDrops overridden

SquidDev opened this issue ยท 1 comments

commented

The current implementation of BlockEnderStorage overrides the List<ItemStack> getDrops(IBlockAccess world, BlockPos pos, IBlockState state, int fortune) method:

public ArrayList<ItemStack> getDrops(IBlockAccess world, BlockPos pos, IBlockState state, int fortune) {

However, this overload is deprecated, one should instead override public void getDrops(NonNullList<ItemStack> drops, IBlockAccess world, BlockPos pos, IBlockState state, int fortune). This makes it consistent with vanilla blocks such as BlockLeaves.

I realise this is a rather petty issue (sorry), but some mods (well, ComputerCraft) calls the latter method, meaning all metadata/NBT was lost when broken with a turtle.

commented

Cheers! Not a petty issue at all!
I'm gathering the new method was added recently, although i cant remember a pr for it recently. I would have assumed the new method delegated but either way ill add this to the list!