Tooltips and functions work unexpected or not at all with swapped crouch and sprint keys.
NoxyNixie opened this issue ยท 6 comments
My crouch key is normally control
while sprint is shift
. Your tooltips seem to be mentioning both shift
, control
and crouch
with various combination of clicking and scrolling. This however does not work if you have my usual keybinds.
I'm having a very hard time figuring out the wand of the lazy builder until I realized that the tooltips did not change when I changed my keybinds to what minecraft default has.
I'm not sure how you'd address this issue but it would be nice if the wand of the lazy builder could work perfectly with my keybinds (control
and shift
being swapped in comparison to minecraft default).
Hmm right you are probably right, I likely have mixed terminology in the tooltips. I'm pretty sure they all just use Ctrl/Shift/Alt instead of checking what the keybinds are, so any sneak
should actually just be shift
in regards to keybind combinations.
However anything to do with clicking an item in combination to shift/sneak would actually be the player sneaking on the server side.
Now the question is, would you want the modifier keys to respect the keybinds? I mean they aren't really in any way related to those, they are just selected in a way that seemed the easiest to use for me, so the most often used features are the simplest key combinations, etc.
Personally I would think that rather than tying them to the sneak keybind, if I'm going to make changes to the mess that are they keybind combos, I should just implement my custom keybind stuff that I've been implementing lately to some of my client-side mods for LiteLoader. That way the player could freely individually select all the keybinds for any of the items. However I'm not entirely sure how well that system would integrate into a Forge mod.
Well for instance sneak+scroll is supposed to move the blue (second marker) position in the direction you are facing. If sneak == control this will switch the mode instead making it impossible to do some of these things.
Many of the key combinations suffer from this issue the above is just one example.
I think not using sneak
but actually looking for control
might solve most of these but I wouldn't actually know for sure.
I trust you can make it better since you already made this awesome mod ;)
That's a good point... the issue is that some of the things are server-side, where keybinds don't exist, but the only "modifier" possible is whether or not the player is sneaking or not. I'll need to go through the code and try to convert everything into client-side originated keybind messages then I guess.
I looked at the code for the hotkey stuff a little while ago, and all of the key combinations actually use the keys on the client side, and then send a packet to the server. So any hotkey combinations actually use Shift, Control etc. and not the player's sneak status. And in contrast, any actions that are "sneak and left or right click on something" actually use the sneak status.
I do have to go through the tooltips and update them to properly refer to Shift instead of sneak in the hotkey combinations... But keeping this in mind, I think there shouldn't be issues in this way of operation? Have you ran into any issues where some things are impossible to do?
Thus far it seems you are correct.
I find it really confusing though to figure out what hotkey combination does what and when I made this issue it actually stopped me from using the wand.
I think it would help tremendously if the info box in the bottom left had hotkey hints:
Here it would help if for instance the toggle key for Replace
was indicated something along the lines of Replace (!T)
. The exclamation character (!
) here is indicating the ALT
key and T
for the toggle key.
Like this, you could assign characters to modifier keys in the style of Auto-hotkeys modifiers:
Symbol | Key |
---|---|
! |
Alt |
^ |
Control |
+ |
Shift |
I'm not sure what else could be done at this time to make the hotkey mess, that the wotlb is, better to understand.
Additionally I just found out that having the Toggle
key on your numpad does now work as expected.
It seems that some of the modifier combinations with a toggle key on the numpad do not work at all.
As an example I had the toggle key on NUMPAD5
and I was trying to switch to bind mode
in Replace 3D
. The key combinations SHIFT + Toggle
does nothing.
When I changed the toggle key to a non numpad key it all worked fine.