gunPowder is being registered as "dustGunpowder" in the OreDict
mezz opened this issue · 10 comments
EnderCore is giving gunpowder the oredict name "dustGunpowder"
https://github.com/SleepyTrousers/EnderCore/blob/master/src/main/java/com/enderio/core/common/OreDict.java#L31
This breaks some expectations about dusts, which are generally crushed up metal ingots. As far as I can tell nothing is using it, and gunpowder already has the oreDict name "gunpowder" give by Forge.
This causes gunpowder to be picked up by Forestry's Miner's backpack, when it belongs in the Hunter's backpack.
Looks like we have @jaredlll08 to thank for this one tterrag1098/ttCore@7643b89
I'm not sure why it was added if it already had a name. Or was that forge oredict added since 2014...
Forge added more oredict names recently:
MinecraftForge/MinecraftForge@d31cf8d
Uh what, it is a dust...
I'm fairly sure the Forge oredict was added later anyway.
On Jun 20, 2016 12:10 AM, "tterrag" [email protected] wrote:
Looks like we have @jaredlll08 https://github.com/Jaredlll08 to thank
for this one tterrag1098/ttCore@7643b89
tterrag1098/ttCore@7643b89I'm not sure why it was added if it already had a name. Or was that forge
oredict added since 2014...—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#47 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFS9xUW0oUsYMc_WDWIpAY5rPo0B5g8Wks5qNb5tgaJpZM4I5Qw0
.
Yes it is a dust irl, but it is not a dust according to oredict convention. There is no gunpowder ingot, or other gunpowder non-dust version.
For now!
mkdir GPiAD; gradle setupDecompWorkspace idea
Though seriously, I prefer dustGunpowder, makes it easier to oredict all
dusts
On Jun 20, 2016 12:17 AM, "mezz" [email protected] wrote:
Yes it is a dust irl, but it is not a dust according to oredict convention.
There is no gunpowder ingot, or other gunpowder non-dust version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#47 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AFS9xeTlmbfJEIVnRl3jkIoLA1wG1CBqks5qNb_7gaJpZM4I5Qw0
.
I am on @jaredlll08's side here, you could argue "convention" all day but you are relying on undefined semantics. However, since it is a dupe registration we will remove it (1.9 only)
Similar issue with blockObsidian
, Forge registers it as obsidian
.
I'd agree here that blockObsidian
is better but it's still a duplicate :/
@mezz One thing I noticed is that forge registers redstone as dustRedstone. So this already contradicts your convention, even though it works out in the end as redstone does belong in the miner's backpack. Either way as I said, we will be removing the duplicate.
Having it mostly correct is good enough for me. I'll probably have to make a blacklist at some point. I'm basing my ideas off of an oredictionary dump of a large kitchen sink pack on 1.7.10. https://gist.github.com/mezz/cf5d1a055e0c7fdb6cab
Having items/blocks registered in multiple oredicts is not a bug per se.
Imagine Thaumcraft using 'parafernalia' oredict and adding to it everything that can be used as infusion stabilizer.
The problem, however, is an inconsistent oredict usage. And 'obsidian' is a good example of the latter.