The Endergetic Expansion

The Endergetic Expansion

25M Downloads

Ender Campfire Incompatible With Healing Campfire & No Hostiles Around Campfire

Brittank88 opened this issue ยท 2 comments

commented

This is in reference to Serilum/.issue-tracker#491.

This is the line that checks for campfires in the world in their code.

This is the function itself, that checks for, in this case, TileEntities of type TileEntityType.CAMPFIRE.

I can see that in Endergetic, the Ender Campfire does extend from the CampfireTileEntity class. However, it seems it doesn't count as TileEntityType.CAMPFIRE still, because it isn't being picked up by the function I linked to above. Other campfires from other mods (such as BYG) work just fine, which is the main reason why I figured I should post an issue here too.

commented

This is an issue on their side.
It's not wise to assume every tile entity campfire in a modded environment will be of type TileEntityType.CAMPFIRE.
A better method of determining campfires would be to use the minecraft:campfires block tag to lessen chances for incompatibilities and give datapack makers the ability to decide which blocks should be affected.

commented

Agreed. Very, very agreed.