The Endergetic Expansion

The Endergetic Expansion

Mods
25M Downloads

[1.16.5-3.0.0] Corrock Tower Configuredfeature cannot be parsed and turned to json

TelepathicGrunt opened this issue ยท 1 comments

commented

When using Endergetic Expansion with Blame on, Blame reports in the log that the Corrock Tower configuredfeature is unabled to be turned back into json (typically for mod compat). https://paste.ee/p/t6egG

The issue is the 256 for count method is too large for the count codec which is limited to -10 to 128. Instead, a simple solution is to swap func_242731_b(256) with withPlacement(Placement.COUNT_EXTRA.configure(new AtSurfaceWithExtraConfig(256, 0F, 0))) since the count extra placement does not have any limit

endergetic/src/main/java/com/minecraftabnormals/endergetic/common/world/features/EEFeatures.java

Line 68 in 5b9ca8c

public static final ConfiguredFeature<?, ?> CORROCK_TOWER = EEFeatures.WEIGHTED_FEATURES.get().withConfiguration(WeightedFeatureConfig.createFromPairs(Pair.of(SMALL_CORROCK_TOWER, 6), Pair.of(MEDIUM_CORROCK_TOWER, 12), Pair.of(LARGE_CORROCK_TOWER, 4))).withPlacement(Features.Placements.PATCH_PLACEMENT).func_242731_b(256);

Hope this helps!

commented

Duplicate of #175