Engineer's Decor

Engineer's Decor

19M Downloads

[Bug] Broken window texture with Better Foliage

rai-en opened this issue ยท 18 comments

commented

Both wooden and steel framed window textures break when installed alongside Better Foliage. Those are the only two affected blocks and the problem doesn't seem to be version specific. It doesn't matter if Better Foliage is enabled for it to occur, just that it's installed. Running without Optifine.

2019-04-25_19 47 37

commented

I'll go into this this weekend. Must have something to do with multilayer rendering (only windows have that). Thanks for taking the time to analyse and going to the bottom of the issue!

commented

Aye, had to use cutout-mipped instead of cutout for multi-layer model.

commented

v1.0.4-b4 dist jar is pushed, could you double check if the issue is also gone on your machine? Cheers!

commented

Can confirm fixed on my end. Thanks! :)

2019-04-26_12 49 13

commented

Perfect, thanks again for going into the matter, that saved me a lot of time! Cheers -

commented

Seems at some point this issue was reintroduced, i'm running engineersdecor-1.12.2-1.0.11-b2 and have this same issue with better foliage .

commented

Reopened, I'll double check.

commented

Quickly double checked with two instances and configs, I cannot reproduce the issue. Looks this will get a tricky one ;)
2019-08-27-check-ed-betterfoliage

commented

Could you zip up the log and drop it into this thread? Maybe this may help to see where the issue comes from. thx -

commented

Capture
2019-08-31_13 05 51
latest.log
Hes the log file, a screenshot in game with the steel windows and the modlist im testing with

commented

Thx. Oh man, nothing to see in the log about model issues in the ED mod. For finding out what it is I have wrapped a testing jar (scheduled for v1.0.12b1), where I removed UV definitions in the glass pane submodel of the window. Maybe the renderer is sensitive to that.
engineersdecor-1.12.2-1.0.12-b1-issue19track.zip. If it works with that I'll rebuild v1.0.11 release to contain the change, otherwise scheduled for the next beta.

commented

2019-08-31_14 33 14
Same issue with the testing jar, it looks fine in inventory though.
The frame does look like its in there just something with the glass part I guess
2019-08-31_14 34 18

commented

I don't get it ;[ . If ok with you I'll wrap up the current release and schedule this to 1.0.12 beta 1. It will involve a lot of fishing in the dark, and I don't want to mess up the release jar with quick changes.

commented

sounds good

commented

Ok, ambient occlusion changed for the window pane, I reverted that for v1.0.12-b1.
There is another thing that crossed my mind: As BF and also the window models use Mipped Cutout models, have you mipmap level at least 1 in your video settings, or 0?

commented

Ok, next try is pushed on curse ;)

commented

Did you have time to give it a check? Cheers -

commented

Closed due to stalling.