Engineer's Decor

Engineer's Decor

19M Downloads

Minecolonies incompatibility

emanuele246gi opened this issue ยท 13 comments

commented

I noticed that there are some rotation issues with Minecolonies and customized buildings, they keep facing the original schematic direction instead of following this specific rotation of the building:
2022-03-06_14 41 06
Minecraft: 1.16.5
Forge: 36.2.29
Engineer's Decor: 1.1.16
Minecolonies: 1.0.456-BETA

commented

Hi, oky let me take a glimpse what this is ;)

commented

Thank you!

commented

What happened to this issue? It's still in 1.18.2

commented

Hi, I likely have to shift it towards 1.19.x (unfortunately a busy times, and I completely forgot to add the fix to the last release). Good that you pinged the issue.

commented

Oky, I tried a quick shot by defining the rotation in my own classes instead of using the default MC block rotation mechanism. Could you take a look at engineersdecor-1.18.2-1.1.25? If it's okay I gonna mark that version from beta to release. Cheers,-

commented

Okay I'll see it right now, thank you for all your efforts tho!

commented

2022-09-24_12 02 19

It doesn't seem to work, those in the right direction were the one I fixed by myself, after the builder finished building

commented

Yay! It worked! Thank you man!

commented

I'm trying it right now, also, the issue exists in Gauges and Switches too ๐Ÿ˜…

commented

Oky the railings had no rotation implementation at all I just see. I quickly added this in the attached jar, could you take a look (I currently don't have a Minecolonies setup and also would need to dig into the matter of structure definition ;/)?

2022-09-25-engineersdecor-1.18.2-1.1.26b1.zip

commented

Very good, thank YOU for your efforts!

commented

Very nice, I'll wait for feedback of another issue an then make a release build. Good that you did into this, I wouldn't have noticed that bug. According to G&S, that's gonna be a bit more interesting - first mod, extended quite from a simple code base, and now due for a refurbishment, that may need some time, even not ported yet to 1.19... Cheers man,-

commented

But I will probably not update my modpack for 1.19 at the moment, versions came out too fast and I didn't finish the 1.18.2 one!