Enhanced Celestials(Fabric) - Blood Moons & Harvest Moons

Enhanced Celestials(Fabric) - Blood Moons & Harvest Moons

5M Downloads

[Bug]: Events occur in not valid moon phases

FernandoCalaza opened this issue ยท 0 comments

commented

Minecraft Version

1.20.1

Enhanced Celestials Version

5.0.0.2

Mod Loader

Forge

Mod Loader Version

47.2.0

Bug Severity

Major

What happened?

Custom events are appering in lunar phases that should not occur. The datapack adds Nemesis variants to the mod's moons event and they should occur in phases [0, 2, 7] (in super [1, 5]). However Nemesis appear incorrectly in phase 3.
what is thisssssss
Image from "after world"

How to reproduce the bug:

  • Create a superflat with the datapack inside;
  • Skip all events initial cooldowns (/time add 25d);
  • Get LunarForecast print (/enhancedcelestials lunarForecast);
  • Find faulty events (before world is here);
  • Go to the day of the faulty event (/time add 98d);
  • Wait for the night arrive;
  • Observe Nemesis Blood in a Last Quarter (phase 3) (after world is here)

How Find faulty events :

  • "Current Lunar forecast:\nSUPER Fishing (in 99d), Nemesis Blood (in 98d), ... , SUPER Nemesis Fishing (in 0d)." (complete in log file).
  • Analyzing this print and separating for each lunar phase, the percentage of nemesis on all 100 nights is.
    [ 0>>33% | 1>>31% | 2>>62% | 3>>8% | 4>>0% | 5>>15% | 6>>0% | 7>>50% ].
  • Looking at the history of the separation into lunar phases, it is possible to notice that this 8% corresponds to the "Nemesis Blood (in 98d)" event occurring in phase 3.

Files:

Mods:

  • CorgiLib-forge-1.20.1-4.0.0.4.jar
  • Enhanced_Celestials-forge-1.20.1-5.0.0.2.jar
  • YeetusExperimentus-Forge-2.3.1-build.6+mc1.20.1.jar

Datapack:

Worlds (before and after)

READ ME:

  • The log sent is from "before world"
  • "Before world" is a copy of the "after world", before using the "/time add 98d " command.
  • This bug happens with 20% of my test worlds and usually occurs with the last 20 days of LunarForecast, in Nemesis events, after adding the 25d. Few times the faulty events were in the middle of the LunarForecast.
  • The other moons event of the mod in Nemesis variants also appear incorrectly in moon phases 3
  • Using an instance called: EC config
  • I used a Python program to find the error for me

latest.log

[13:38:17] [main/INFO]: ModLauncher running: args [--username, Player, --version, EC config, --gameDir, C:...\AppData\Roaming.minecraft\versions\EC config, --assetsDir, C:...\AppData\Roaming.minecraft\assets, --assetIndex, 5, --uuid, 3e33d16b-d2b8-11ea-8536-b42e996a7d7a, --accessToken, ????????, --clientId, null, --xuid, null, --userType, mojang, --versionType, release, --width, 925, --height, 530, --launchTarget, forgeclient, --fml.forgeVersion, 47.2.0, --fml.mcVersion, 1.20.1, --fml.forgeGroup, net.minecraftforge, --fml.mcpVersion, 20230612.114412, --fullscreen]
[13:38:17] [main/INFO]: ModLauncher 10.0.9+10.0.9+main.dcd20f30 starting: java version 17.0.3 by Microsoft; OS Windows 10 arch amd64 version 10.0
[13:38:17] [main/INFO]: Loading ImmediateWindowProvider fmlearlywindow
[13:38:18] [main/INFO]: Trying GL version 4.6
[13:38:18] [main/INFO]: Requested GL version 4.6 got version 4.6
[13:38:18] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.5 Source=union:/C:/.../AppData/Roaming/.minecraft/libraries/org/spongepowered/mixin/0.8.5/mixin-0.8.5.jar%23100!/ Service=ModLauncher Env=CLIENT
[13:38:18] [pool-2-thread-1/INFO]: GL info: Intel(R) HD Graphics 520 GL version 4.6.0 - Build 30.0.101.3111, Intel
[13:38:18] [main/INFO]: Found mod file CorgiLib-forge-1.20.1-4.0.0.4.jar of type MOD with provider {mods folder locator at C:...\AppData\Roaming.minecraft\versions\EC config\mods}
[13:38:18] [main/INFO]: Found mod file Enhanced_Celestials-forge-1.20.1-5.0.0.2.jar of type MOD with provider {mods folder locator at C:...\AppData\Roaming.minecraft\versions\EC config\mods}
[13:38:18] [main/INFO]: Found mod file YeetusExperimentus-Forge-2.3.1-build.6+mc1.20.1.jar of type MOD with provider {mods folder locator at C:...\AppData\Roaming.minecraft\versions\EC config\mods}
[13:38:19] [main/WARN]: Mod file C:...\AppData\Roaming.minecraft\libraries\net\minecraftforge\fmlcore\1.20.1-47.2.0\fmlcore-1.20.1-47.2.0.jar is missing mods.toml file
[13:38:19] [main/WARN]: Mod file C:...\AppData\Roaming.minecraft\libraries\net\minecraftforge\javafmllanguage\1.20.1-47.2.0\javafmllanguage-1.20.1-47.2.0.jar is missing mods.toml file
[13:38:19] [main/WARN]: Mod file C:...\AppData\Roaming.minecraft\libraries\net\minecraftforge\lowcodelanguage\1.20.1-47.2.0\lowcodelanguage-1.20.1-47.2.0.jar is missing mods.toml file
[13:38:19] [main/WARN]: Mod file C:...\AppData\Roaming.minecraft\libraries\net\minecraftforge\mclanguage\1.20.1-47.2.0\mclanguage-1.20.1-47.2.0.jar is missing mods.toml file
[13:38:19] [main/INFO]: Found mod file fmlcore-1.20.1-47.2.0.jar of type LIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@3c89bb12
[13:38:19] [main/INFO]: Found mod file javafmllanguage-1.20.1-47.2.0.jar of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@3c89bb12
[13:38:19] [main/INFO]: Found mod file lowcodelanguage-1.20.1-47.2.0.jar of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@3c89bb12
[13:38:19] [main/INFO]: Found mod file mclanguage-1.20.1-47.2.0.jar of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@3c89bb12
[13:38:19] [main/INFO]: Found mod file client-1.20.1-20230612.114412-srg.jar of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@3c89bb12
[13:38:19] [main/INFO]: Found mod file forge-1.20.1-47.2.0-universal.jar of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@3c89bb12
[13:38:19] [main/INFO]: No dependencies to load found. Skipping!
[13:38:25] [main/INFO]: Compatibility level set to JAVA_17
[13:38:25] [main/INFO]: Launching target 'forgeclient' with arguments [--version, EC config, --gameDir, C:...\AppData\Roaming.minecraft\versions\EC config, --assetsDir, C:...\AppData\Roaming.minecraft\assets, --uuid, 3e33d16b-d2b8-11ea-8536-b42e996a7d7a, --username, Player, --assetIndex, 5, --accessToken, ????????, --clientId, null, --xuid, null, --userType, mojang, --versionType, release, --width, 925, --height, 530, --fullscreen]
[13:38:26] [main/WARN]: Reference map '${refmap_target}refmap.json' for corgilib.forge.mixins.json could not be read. If this is a development environment you can ignore this message
[13:38:30] [main/WARN]: Failed to add PDH Counter: \Paging File(_Total)% Usage, Error code: 0xC0000BB8
[13:38:30] [main/WARN]: Failed to add counter for PDH counter: \Paging File(_Total)% Usage
[13:38:31] [main/WARN]: Disabling further attempts to query Paging File.
[13:38:32] [main/WARN]: COM exception: Invalid Query: SELECT PERCENTUSAGE FROM Win32_PerfRawData_PerfOS_PagingFile
[13:38:41] [Datafixer Bootstrap/INFO]: 188 Datafixer optimizations took 1521 milliseconds
[13:38:45] [Render thread/WARN]: Assets URL 'union:/C:/.../AppData/Roaming/.minecraft/libraries/net/minecraft/client/1.20.1-20230612.114412/client-1.20.1-20230612.114412-srg.jar%23162!/assets/.mcassetsroot' uses unexpected schema
[13:38:45] [Render thread/WARN]: Assets URL 'union:/C:/...AppData/Roaming/.minecraft/libraries/net/minecraft/client/1.20.1-20230612.114412/client-1.20.1-20230612.114412-srg.jar%23162!/data/.mcassetsroot' uses unexpected schema
... 20 more
[13:38:46] [Render thread/INFO]: Setting user: Player
[13:38:46] [Render thread/INFO]: Backend library: LWJGL version 3.3.1 build 7
[13:38:47] [modloading-worker-0/INFO]: Forge mod loading, version 47.2.0, for MC 1.20.1 with MCP 20230612.114412
[13:38:47] [modloading-worker-0/INFO]: MinecraftForge v47.2.0 Initialized
[13:38:50] [Render thread/INFO]: Reloading ResourceManager: vanilla, mod_resources
[13:38:50] [Worker-Main-1/INFO]: Initialized enhancedcelestials network!
[13:38:50] [Worker-Main-1/INFO]: Initializing network...
[13:38:50] [Worker-Main-1/INFO]: Initialized network!
[13:38:50] [Forge Version Check/INFO]: [forge] Starting version check at https://files.minecraftforge.net/net/minecraftforge/forge/promotions_slim.json
[13:38:50] [Worker-Main-1/INFO]: Found unifont_all_no_pua-15.0.06.hex, loading
[13:38:51] [Forge Version Check/INFO]: [forge] Found status: UP_TO_DATE Current: 47.2.0 Target: null
[13:38:59] [Render thread/WARN]: Missing sound for event: minecraft:item.goat_horn.play
[13:38:59] [Render thread/WARN]: Missing sound for event: minecraft:entity.goat.screaming.horn_break
[13:38:59] [Render thread/INFO]: OpenAL initialized on device OpenAL Soft on Fones de ouvido / Alto falantes (Realtek Audio)
[13:38:59] [Render thread/INFO]: Sound engine started
[13:38:59] [Render thread/INFO]: Created: 1024x512x0 minecraft:textures/atlas/blocks.png-atlas
[13:38:59] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/signs.png-atlas
[13:38:59] [Render thread/INFO]: Created: 512x512x0 minecraft:textures/atlas/shield_patterns.png-atlas
[13:38:59] [Render thread/INFO]: Created: 512x512x0 minecraft:textures/atlas/banner_patterns.png-atlas
[13:38:59] [Render thread/INFO]: Created: 1024x1024x0 minecraft:textures/atlas/armor_trims.png-atlas
[13:38:59] [Render thread/INFO]: Created: 128x64x0 minecraft:textures/atlas/decorated_pot.png-atlas
[13:38:59] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/chest.png-atlas
[13:38:59] [Render thread/INFO]: Created: 512x256x0 minecraft:textures/atlas/beds.png-atlas
[13:38:59] [Render thread/INFO]: Created: 512x256x0 minecraft:textures/atlas/shulker_boxes.png-atlas
[13:39:01] [Render thread/WARN]: Shader rendertype_entity_translucent_emissive could not find sampler named Sampler2 in the specified shader program.
[13:39:02] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/particles.png-atlas
[13:39:02] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas
[13:39:02] [Render thread/INFO]: Created: 128x128x0 minecraft:textures/atlas/mob_effects.png-atlas
[13:39:02] [Realms Notification Availability checker #1/INFO]: Could not authorize you against Realms server: Invalid session id
[13:39:04] [Render thread/ERROR]: Illegal format found {0,choice,0#Sem mods|1#1<{0} mods} carregados
[13:39:08] [Render thread/INFO]: Injecting existing registry data into this CLIENT instance
[13:39:13] [Render thread/INFO]: Loaded 7 recipes
[13:39:13] [Render thread/INFO]: Loaded 1271 advancements
[13:39:14] [Server thread/INFO]: Starting integrated minecraft server version 1.20.1
[13:39:14] [Server thread/INFO]: Generating keypair
[13:39:15] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[13:39:21] [Render thread/INFO]: Preparing the spawn area: 0%
[13:39:21] [Render thread/INFO]: Preparing the spawn area: 0%
[13:39:21] [Render thread/INFO]: Preparing the spawn area: 0%
[13:39:21] [Render thread/INFO]: Preparing the spawn area: 0%
[13:39:21] [Render thread/INFO]: Preparing the spawn area: 0%
[13:39:21] [Render thread/INFO]: Preparing the spawn area: 0%
[13:39:21] [Render thread/INFO]: Preparing the spawn area: 0%
[13:39:21] [Render thread/INFO]: Preparing the spawn area: 0%
[13:39:21] [Render thread/INFO]: Preparing the spawn area: 0%
[13:39:21] [Render thread/INFO]: Preparing the spawn area: 0%
[13:39:21] [Render thread/INFO]: Preparing the spawn area: 0%
[13:39:21] [Render thread/INFO]: Preparing the spawn area: 0%
[13:39:21] [Render thread/INFO]: Preparing the spawn area: 0%
[13:39:22] [Render thread/INFO]: Preparing the spawn area: 17%
[13:39:22] [Render thread/INFO]: Preparing the spawn area: 67%
[13:39:23] [Render thread/INFO]: Preparing the spawn area: 85%
[13:39:23] [Server thread/INFO]: Successfully initialized permission handler forge:default_handler
[13:39:23] [Render thread/INFO]: Time elapsed: 7779 ms
[13:39:23] [Server thread/INFO]: Changing view distance to 2, from 10
[13:39:23] [Server thread/INFO]: Changing simulation distance to 5, from 0
[13:39:24] [Render thread/WARN]: Unable to parse the boolean system property 'java.net.preferIPv6Addresses':system - using the default value: false
[13:39:26] [Netty Local Client IO #0/INFO]: Connected to a modded server.
[13:39:26] [Server thread/INFO]: Player[local:E:43e0c0c1] logged in with entity id 83 at (2.5, -60.0, -1.5)
[13:39:26] [Server thread/INFO]: Playerentrou no jogo
[13:39:27] [Render thread/INFO]: Loaded 2 advancements
[13:39:29] [Server thread/INFO]: Saving and pausing game...
[13:39:29] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Novo mundo]'/minecraft:overworld
[13:39:31] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Novo mundo]'/minecraft:the_nether
[13:39:31] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Novo mundo]'/minecraft:the_end
[13:39:32] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 3781ms or 75 ticks behind
[13:39:53] [Server thread/INFO]: [Player: Current Lunar forecast:
SUPER Fishing (in 99d), Nemesis Blood (in 98d), Nemesis Harvest (in 97d), Fishing (in 96d), Harvest (in 94d), Blood (in 93d), Nemesis Harvest (in 92d), SUPER Nemesis Blood (in 91d), Fishing (in 89d), Harvest (in 84d), SUPER Nemesis Harvest (in 83d), Fishing (in 82d), Nemesis Harvest (in 81d), Blood (in 80d), Nemesis Fishing (in 76d), Harvest (in 75d), Fishing (in 74d), Nemesis Harvest (in 73d), SUPER Nemesis Fishing (in 72d), Nemesis Fishing (in 71d), Nemesis Blood (in 70d), Blood (in 69d), Fishing (in 66d), Nemesis Fishing (in 65d), SUPER Blood (in 64d), Nemesis Harvest (in 62d), Harvest (in 61d), Fishing (in 58d), Blood (in 55d), Nemesis Fishing (in 54d), Harvest (in 51d), Fishing (in 50d), Nemesis Blood (in 49d), SUPER Fishing (in 48d), Nemesis Fishing (in 47d), Nemesis Harvest (in 46d), Blood (in 42d), Harvest (in 41d), MEGA MOON (in 40d), Nemesis Harvest (in 38d), Fishing (in 35d), Harvest (in 34d), Nemesis Fishing (in 33d), SUPER Nemesis Fishing (in 32d), Nemesis Blood (in 31d), Harvest (in 26d), SUPER Nemesis Blood (in 24d), Nemesis Harvest (in 23d), Fishing (in 21d), Harvest (in 18d), Nemesis Fishing (in 17d), MEGA MOON (in 16d), Blood (in 15d), Fishing (in 14d), Harvest (in 10d), Nemesis Blood (in 9d), SUPER Harvest (in 8d), Fishing (in 7d), Nemesis Harvest (in 6d), Harvest (in 2d), Blood (in 1d), SUPER Nemesis Fishing (in 0d).]
[13:39:53] [Render thread/INFO]: [System] [CHAT] Current Lunar forecast:\nSUPER Fishing (in 99d), Nemesis Blood (in 98d), Nemesis Harvest (in 97d), Fishing (in 96d), Harvest (in 94d), Blood (in 93d), Nemesis Harvest (in 92d), SUPER Nemesis Blood (in 91d), Fishing (in 89d), Harvest (in 84d), SUPER Nemesis Harvest (in 83d), Fishing (in 82d), Nemesis Harvest (in 81d), Blood (in 80d), Nemesis Fishing (in 76d), Harvest (in 75d), Fishing (in 74d), Nemesis Harvest (in 73d), SUPER Nemesis Fishing (in 72d), Nemesis Fishing (in 71d), Nemesis Blood (in 70d), Blood (in 69d), Fishing (in 66d), Nemesis Fishing (in 65d), SUPER Blood (in 64d), Nemesis Harvest (in 62d), Harvest (in 61d), Fishing (in 58d), Blood (in 55d), Nemesis Fishing (in 54d), Harvest (in 51d), Fishing (in 50d), Nemesis Blood (in 49d), SUPER Fishing (in 48d), Nemesis Fishing (in 47d), Nemesis Harvest (in 46d), Blood (in 42d), Harvest (in 41d), MEGA MOON (in 40d), Nemesis Harvest (in 38d), Fishing (in 35d), Harvest (in 34d), Nemesis Fishing (in 33d), SUPER Nemesis Fishing (in 32d), Nemesis Blood (in 31d), Harvest (in 26d), SUPER Nemesis Blood (in 24d), Nemesis Harvest (in 23d), Fishing (in 21d), Harvest (in 18d), Nemesis Fishing (in 17d), MEGA MOON (in 16d), Blood (in 15d), Fishing (in 14d), Harvest (in 10d), Nemesis Blood (in 9d), SUPER Harvest (in 8d), Fishing (in 7d), Nemesis Harvest (in 6d), Harvest (in 2d), Blood (in 1d), SUPER Nemesis Fishing (in 0d).
[13:40:38] [Render thread/INFO]: Stopping!
[13:40:38] [Server thread/INFO]: Player lost connection: Desconectado
[13:40:38] [Server thread/INFO]: Player saiu do jogo
[13:40:38] [Server thread/INFO]: Stopping singleplayer server as player logged out
[13:40:38] [Server thread/INFO]: Stopping server
[13:40:38] [Server thread/INFO]: Saving players
[13:40:38] [Server thread/INFO]: Saving worlds
[13:40:41] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Novo mundo]'/minecraft:overworld
[13:40:41] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Novo mundo]'/minecraft:the_nether
[13:40:41] [Server thread/INFO]: Saving chunks for level 'ServerLevel[Novo mundo]'/minecraft:the_end
[13:40:41] [Server thread/INFO]: ThreadedAnvilChunkStorage (world before): All chunks are saved
[13:40:41] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[13:40:41] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[13:40:41] [Server thread/INFO]: ThreadedAnvilChunkStorage: All dimensions are saved