Enhanced Celestials - Blood, Blue, & Harvest (Super) Moons

Enhanced Celestials - Blood, Blue, & Harvest (Super) Moons

26M Downloads

[Bug]: Entity filters don't work

DraconicArcher opened this issue ยท 1 comments

commented

Minecraft Version

1.19.2

Enhanced Celestials Version

2.1.0.6

Mod Loader

Forge

Mod Loader Version

43.4.0

Bug Severity

Minor

What happened?

When I try to use the entity filters from the wiki to build a datapack, it tells me my datapack is invalid. I have tried replacing "enhancedcelestials" with "corgilib" and always verify my files are valid jsons.

If this is fixed on 1.19.2 and 1.20.1, I can make more interesting add-ons.

latest.log

latest.log

commented

I've also been struggling with the lack of accurate documentation for datapacks. Even the mod's own default lunar events use a different syntax than what's described on the wiki. I've been able to make several lunar events, but being unable to filter which entities are effected by some portions of the config when I'm told that it should be possible is frustrating.

I've made an example datapack that does nothing but change the filter syntax of the blue moon event's mob effect to its example that's currently shown on the wiki.

ec_test.zip

What's in the mob effects section for the blue moon in the mod's jar file:

"mob_effects": [
      {
        "filter": {
          "type": "corgilib:any"
        },
        "mob_effect": {
          "ambient": true,
          "amplifier": 0,
          "duration_in_ticks": 1210,
          "effect": "minecraft:luck",
          "show_icon": false,
          "visible": false
        }
      }
    ]

What the wiki has instead(and what the included datapack changes that specific section to):

"mob_effects": [
	{
	  "mob_effect": {
	  "ambient": true,
	  "amplifier": 4,
	  "duration_in_ticks": 1210,
	  "effect": "minecraft:luck",
	  "show_icon": false,
	  "visible": false
	  },
	  "filter": {
		  "config": {
		  },
		  "type": "enhancedcelestials:any"
	  }
	}
]

At the very least, the wiki's current contents do not accurately reflect how to customize the most recent released version of the mod(Enhanced Celestials 1.20.1-5.0.1.0 at the time of writing).

latest.log