EnhancedVisuals

EnhancedVisuals

12M Downloads

These blood can eventually make you blind.

vrgtics opened this issue · 8 comments

commented

I don't know is it necessary to actually make it affect any Gui interface, yes it's happened Any Gui not only there.
lol, how do I watch?

20220505-235559

  • I have a suggestion of making these blood effect to liitle transparency

also can make me drop fps, but that's alright.

commented

They should fade over time.

commented

They should fade over time.

you have no idea what's the problem when you actually using.
I can give you More above my picture, I'm on the Mod Menu list, which mean I'm Pausing the Game, which mean this mod is designed in-game processing, which mean fading doesn't operate while game pauses, well that sucks. 🤦‍♀️🤦‍♀️🤦‍♀️

commented

Confirmed - the overlay does not tick when you are not in-game. This will persist even to the main menu. Happens with all overlays, including location-based ones, such as the "slender" overlay.

commented

I tested the newest version in fabric minecraft 1.19 and it works in the same way as forge. I think this issue has been fixed in the meantime.

commented

The issue is that END_CLIENT_TICK does not tick in the menu. The RenderTickEvent in Forge however does. This means effects will dissolve on forge but not on fabric. I got no idea how to fix this. Is there an event in fabric which also ticks in the main menu?

commented

Where precisely does RenderTickEvent trigger?

commented

In Minecraft.runTick(boolean):

...
if (!this.noRender) {
         net.minecraftforge.event.ForgeEventFactory.onRenderTickStart(this.pause ? this.pausePartialTick : this.timer.partialTick);
         this.profiler.popPush("gameRenderer");
         this.gameRenderer.render(this.pause ? this.pausePartialTick : this.timer.partialTick, i, p_91384_);
         this.profiler.popPush("toasts");
         this.toast.render(new PoseStack());
         this.profiler.pop();
         net.minecraftforge.event.ForgeEventFactory.onRenderTickEnd(this.pause ? this.pausePartialTick : this.timer.partialTick);
}
...
commented

Idea: Mixin to the GameRenderer