Enigmatic Legacy

Enigmatic Legacy

10M Downloads

Allow other mods to change the amount of curses a player has

NyanMC opened this issue ยท 0 comments

commented

Currently the amount of curses the player is considered to have (a value used exclusively by the Scroll of a Thousand Curses) is determined by the method getCurseAmount in SuperpositionHandler, which merely counts the amount of curse enchantments plus an additional 7 if the cursed ring is equipped. While this functions well enough for the base mod, it becomes difficult for other mods to add additional non-vanilla curses.

Currently, one of my mods adds to the curse total by writing a mixin into this very method and adding curses where necessary. I do not want to have to do this, as it is bad practice to mixin into other mods, however there is no other way to fully implement the functionality I want to add otherwise. The mod with this mixin is currently only on 1.19.2, however it will be on 1.20.1 once its required dependency updates in which this issue would become more relevant as this mod appears to still be actively developed on that version.