[EMF] Entity Model Features [Fabric & Forge]

[EMF] Entity Model Features [Fabric & Forge]

45M Downloads

Texture override mess up villagers layers [Bug - models]

SebSemos opened this issue · 3 comments

commented

Using a texture override in the villager models makes the biome and job outfit weird.
Biomes seems to only render the pants, and jobs only the hat?
First picture below is with the vanilla path to the villager texture in blue for better contrast (♪I'm blue dadadeee...♪♪ lol)
Second picture is with a texture override in the villager model.

Image

Image

I pasted all the textures in this picture to compare where it show and not. I don't understand why the pants are shown. There is no sign of the little crown they have either. So it's not the texture beiing just blue. I think it doesn't render but the pant.
Image

I tested with only EMF/ETF (latest) and mod menu on 1.21.5 (I discover that doing an udpate in like 1.21 iirc, been a few month)

I took the villager model exported. Here is the pack with the override active:
test villagers.zip

Expected behavior
Either to retain the biome/job outfit or to not display them at all when using a texture override.

I also thought about another solution. We can have armor models. Could it be we have villagers layer models?

With layers models: they would have the same parts as villagers and would get the textures in the vanilla folders
I think this would allow for a direct compat between packs that change villager models and pack that add diversity to the biome outfits (my goal when I found the issue actually). For ex of a player villager pack, you would just mixel a bit the head (don't tell Thanos!) and change the cubes for the arms.

Ex how it would be in the rp:
Image

Also, might be related to #260 ?

Also, Forge guard villagers also use the same way to render biomes now. If you add this layer thing, that would be amazing if it extend to mods that utilize this mechanic too :)

commented

Checking if still here in 1.21.6 (it is) I noticed that the pack I provide for the texture suffix issue (#364) makes it so some proffessions are not displayed the same beetween both packs. 🤷‍♂️

The pack for this issue:
Image

The pack from #364:
Image

It seem that the incorrect profession display is only for the base texture, texture2 or 3 and 4 looks to be working
Biome outfits doesn't work no matter tho.
I'll give it more testing anytime soon. Just wanted to share this for now as it may hint the issue :)

commented

So, I know you hate me for wanting to use these overrides 😂 I have tried some more stuff, and noticed results variate if the model has a suffix or not.

Here is a summary (for a villager)
Image
And yeah for model with a suffix the path shown in chat is just the vanilla one, not the override.

villager30.jem
Image
vs villager.jem
Image

Not sure why "base textures" and total are not the same number too, I just reloaded the pack after changing villager30 to villager it the jem.propertie

I also did some test with forge Guard villager (1.21.1) wich use this layer technique too. And it seems to have the same issues

I know I would love to be able to edit those layers like we can fro amor, but I would also be fine with no rendering at all for models with a suffix. :)

commented

I'll be looking into these eventually as part of a bigger change in how these textures get applied