[EMF] Entity Model Features [Fabric & Forge]

Describe the bug
Crash with Better End. There was no crash on EMF v2.4.1

Crashlog
Crash: https://gnomebot.dev/paste/mclogs/oeh4jdW
Log: https://gnomebot.dev/paste/mclogs/tTuKgsg

Minecraft Version: 1.20.1 Forge 47.4.0
EMF version: 3.0.1

Can confirm. Issue can be reproduced reliably with EMF and ETF + BetterEnd, FFApi, BCLib, and Connector.
Backdating to 2.4.1 & 6.2.9 solves it, but...

Entity_Model_Features/src/main/java/traben/entity_model_features/mixin/mixins/MixinModel.java

Line 42 in 0a4a15c

//$$ if (EMF.testForForgeLoadingError()) return;

Seems like the culprit, but I assume the core of it is betterend (i.e. connector) loading it in an earlier layer before the mod list gets constructed.
Honestly I'm more confused on why 2.4.1 DOES work, nothing is popping out to me as overly different.

I can confirm this Issue.

I have confirmed this issue with an entirely unrelated set of mods from another user. Solution was the same, backdating to the previous versions worked fine. Connector wasn't involved this time.
The log is here, but there is no reason for me to suspect emf/etf are the cause. The only reason I even thought of the solution is because this issue exists and I've confirmed it manually.

It isn't getting logged anywhere I've been able to see, but something's not right with 3.0.1 and 7.0.2.

Seems to relate with Sinytra/ConnectorExtras#72

This is caused by ETF (NeoForge mod) using ModList instead of LoadingModList and invoking it too early.

that is something i can work with

Share to