[EMF] Entity Model Features [Fabric & Forge]

[EMF] Entity Model Features [Fabric & Forge]

28M Downloads

Breaks other mods that read entity models

MehVahdJukaar opened this issue ยท 13 comments

commented

Noticed with fresh animations and supplementaries. Other mods are known as well.
Basically just accessing an entity model say in a tile entity renderer causes either the model itself to be rendered invisible or the entity model itself to be altered even tho the access did not modify any of it, also because it cant. Can't go into further detail as I can't test now but I've had countless reports of this mod breaking my mod

commented

I can confirm this. It's certainly something to do with the mixins. It's very apparent when I use the Cute Mob Models resource pack. it messes up the tile entity behavior

commented

can you link these mods?
and what emf version?
does it still happen if you set "try to prevent emf models being overridden" to off?

commented

I will need to know how to replicate this also

commented

simply loading etf emf, supplementaries and fresh animations doesn't have any invisible entity models nor block entities that i can see.

I assume there is more to triggering this?

commented

Can you please fix this? I keep getting reports of my mods supposedly not working correctly when EMF is on. It makes my models invisible

commented

I know that some people reported having some enderman model being messed up with another texture pack by simply having the block on. The report of those heads being invisible however came in today so Im pretty sure thats still a thing with newest version.

commented

ill do some tests.
I had reports of this happen with Supplementaries with Fresh Animations.
Block in question is Enderman Head Block. idk if there could be more to trigger this

commented

ah yes the endermen head is invisible, i'll look into it

commented

ah yes the endermen head is invisible, i'll look into it

Any updates on the situation?

commented

it's top of the list for the next emf update but that might be a while

commented

Okay so this was annoyingly obvious once I actually got to looking at it.

Fresh tends to do one simple thing with a lot of his models to make the head movements match the body, he makes the head parts empty and adds a fake head box inside another part usually the body.

Since supplementaries directly uses ModelLayers.ENDERMAN it is reading the fresh animations enderman.jem and having a blank head.

There are 2 solutions:

  1. remove or fix the FA enderman CEM model, and tell all of your users, with this issue, this for the rest of time...
    or
  2. (probably better) register your own custom ModelLayer e.g. Supplementaries.ENDERMAN_HEAD you can still directly copy the enderman model factory but as long as the ModelLayer connected to it has a different Id to "minecraft:enderman" it will not read enderman.jem

TL;DR,
Fresh animations enderman.jem doesnt have a head so all is technically working correctly.
EMF connects CEM models to the specific ModelLayers themselves, if you register a seperate ENDERMAN_HEAD ModelLayers EMF will not touch it, unless someone makes a jem specifically for your new model layer.

commented

OptiFine likely doesnt have this issue because their CEM models are hard coded, as in only the enderman entity renderer reads enderman.jem.

EMF injects into the model loader and is thus able to apply to all models, even modded ones.

To replicate OptiFine in this I would have to cripple EMF and rewrite it to do ,much less :/ bringing about some of the same compatibility issues OptiFine has, atleast where it comes to models