[ETF] Entity Texture Features - [Fabric & Forge]

[ETF] Entity Texture Features - [Fabric & Forge]

38M Downloads

Incorrect enumeration of random textures

coornio opened this issue ยท 2 comments

commented

This was debugged using the John Smith Legacy (v6) for 1.18.1 resource pack.

I noticed that there was a greatly reduced mob variety. It was fairly easy to test with the creeper textures due to their distinctive designs and their modest amount of skins in this pack. It uses the assets/minecraft/optifine/mob path for random textures, and it counts them from index 2 and up. Default textures for entities are present under assets/minecraft/textures.

This is what it looks like by default with this mod enabled:
2022-02-13_23 12 26

The skins depicted here are ordered from right to left. Rightmost is the default skin (1), and leftmost is skin 5. However, the skins shown with the mod, from right to left, are actually 3, 4, 3, 3, 1. Something is very wrong.

I tried as an experiment to take the default skin and placed it in the respective folders under optifine/mob where the extra skins were, then added 1 as a suffix to the name of each skin. Rebooted the game, and this is the result:
2022-02-13_20 38 18

NOW the skins are showing properly. Something is wrong with how the mod is counting the skins, possibly some weird off-by-one situation in the calculations when it checks for an index starting from 2 rather than 1. Below I will list all the creeper skins for reference so you can confirm their order as well:

creeper1
creeper2
creeper3
creeper4
creeper5

Please have a look into this! I'd like to continue using this mod without having to modify my resource pack to work! :)

commented

you were dead on :) it was not handling counting from 2 correctly, it's fixed as of V2.1.4 which should release tonight

commented

Cheers! <3