[ETF] Entity Texture Features - [Fabric & Forge]

Describe the issue

What happened?
I'm experiencing huge lag spikes when players join server's lobby.
What were you doing when it happened?
Playing on server revage.net. Open FPS graph (F3+2) and observe it while staying in the lobby while players are joining.
Does this issue also occur with OptiFine? [yes/no]
I don't use OF.

Screenshots

Crash log

No crashes.

My setup:

Minecraft version: 1.21.4
ModLoader: Fabric
ETF Version: 6.2.9
Does the issue persist with only ETF installed?: Yes, while testing I was only using ETF and ViaFabricPlus (the server is outdated)
Have you checked the FAQ in the Readme, or Discord, to see if it is a known issue?: Yes, I didn't find any mentions of this issue anywhere.
Resource packs applied: None

I also was trying to reproduce this issue on a local 1.21.4 Fabric server but it's not reproducible in that case. Also I've noticed that this lag only happens when player's spawn point in your FOV, so it doesn't happen if you watch in opposite direction.

do you know how to use the spark mod to get a client profile? one of those would be very handy

Looks like I found the source of problem. Spark profile.

Entity_Texture_Features/common/src/main/java/traben/entity_texture_features/features/player/ETFPlayerTexture.java

Line 107 in 17d4725

NativeImage vanilla = getSkinOfPlayer(player, rendererGivenSkin);

Lags are coming from texture downloader (is it done on render thread?).

I'll look into it

Share to