[ETF] Entity Texture Features - [Fabric & Forge]

[ETF] Entity Texture Features - [Fabric & Forge]

38M Downloads

entity spawned on soul sand or mud use default texture when using the blocks rule

TheOnlyJoeEnderman opened this issue ยท 14 comments

commented

I think it's because they spawn 1/16 a block above the block or something
2022-06-19_11 58 06
2022-06-19_12 14 06
2022-06-19_12 14 12
2022-06-19_12 22 16
?

I hope the images are helpful. I can copy and paste the properties file, but you can see everything else works. I set the texture to spawn on dirt for debug reasons.

commented

Unfortunately the update did not fix the issue. I'll just work around that, since I don't need the block feature in this instance, biome will work fine. I can't think of any other times I'll need partial blocks for this feature.

commented

strange I am sure it worked in my testing, i will try and get this working again

commented

I can provide pictures or video, but it's literally doing the same thing as the older version. At first I thought I put the wrong version in my mods folder, so I checked the curseforge page and it was the same version.

I had a theory that any bugfix you made might make entities spawned on lily pads think they spawned on water. But that wouldn't be the case if the reason entites were showing the wrong texture was because of a bug in Vanilla. I don't know what the code is doing under there, so I could be completely wrong about what's happening.

commented

I accidentally closed it. Github on mobile is weird.

commented

what the code did was check the block directly below a mobs feet, this would round to the next lowest block if they were in a half/partial block like soulsand or lillies. I expanded the check to use the block its inside of too which would therefore count soulsand or lillies, I guess my testing was not thorough enough though, perhaps i spawned no ai mobs on the soulsand and they didn't fall into the partial block

commented

i'll update when i have a fix out

commented

Thanks

commented

This affects the latest two 1.19 releases of the mod. I haven't checked other versions.

commented

i'll look into this it is very much due the shortness of those blocks, i'm thinking I will extend the block check to check blocks they are inside of as well

commented

this fix will be in version 3.1.4 tonight

commented

the fixed version is uploaded now

commented

Wow, that was fast.

commented

it was a small issue that was dependant on certain settings hence why it didn't affect my testing, it has been fixed in 4.0.beta.3 on curseforge, i will close this issue when its in a stable release

commented

fix in V4.0