heatProtection does not affect received Temperature or return to 0.
Pursec opened this issue ยท 1 comments
Hot environment protection never goes back down/to 0, and also does not affect the calculated temperature on the player.
- Hold a warming stone and check via /info the cold environment protection build up
- Remove the warming stone from hand, and check via /info the cold environment protection go down to 0.
- Repeat process with ice packs, hot environment protection only builds up but never goes back down.
- Presumably (to my rough understanding of your mod) this is also nullifying the protection against heat that is meant to be provided, see code below for why
Added code comments for explanation.
Taken from your TemperatureAspects.java:
// Calculation for heatResistiance, see that the checked calculatingTemperature to consider heatResistance is positive, "gaining heat"
if (calculatingTemperature > 0) {
int heatResistance = temperatureManager.getPlayerHeatResistance();
if (heatResistance > 0) {
if (heatResistance >= temperatureDifference) {
calculatingTemperature = 0;
temperatureManager.setPlayerHeatResistance(heatResistance - temperatureDifference);
} else {
calculatingTemperature += temperatureDifference;
temperatureManager.setPlayerHeatResistance(0);
}
}
// Calculation for heatProtection, the checked calculatedTemperature here must be negative, "loosing heat", meaning that this never evals to true when intended.
// Only in a "hot environment or above, but already cooling down".
// Because of this the calculatingTemperature never gets set to 0 (player receives the pre-protection temperature
// AND the heatProtection never gets subtracted per tick by temperatureDifference resulting in the static behavior seen via the /info testing
if (calculatingTemperature < 0) {
temperatureDifference = Math.abs(calculatingTemperature);
int heatProtection = temperatureManager.getPlayerHeatProtectionAmount();
if (heatProtection > 0) {
if (heatProtection >= temperatureDifference) {
calculatingTemperature = 0;
temperatureManager.setPlayerHeatProtectionAmount(heatProtection - temperatureDifference);
} else {
calculatingTemperature -= temperatureDifference;
temperatureManager.setPlayerHeatProtectionAmount(0);
}
}
}
}
}
Parallel code for the coldResistance and coldProtection, presumably the intended implantation considering seen affect in-game
Both calculatingTemperatures are needed to be negative, thus "losing heat" to eval to true
if (calculatingTemperature < 0) {
int coldResistance = temperatureManager.getPlayerColdResistance();
if (coldResistance > 0) {
if (coldResistance >= temperatureDifference) {
calculatingTemperature = 0;
temperatureManager.setPlayerColdResistance(coldResistance - temperatureDifference);
} else {
calculatingTemperature += temperatureDifference;
temperatureManager.setPlayerColdResistance(0);
}
}
if (calculatingTemperature < 0) {
temperatureDifference = Math.abs(calculatingTemperature);
int coldProtection = temperatureManager.getPlayerColdProtectionAmount();
if (coldProtection > 0) {
if (coldProtection >= temperatureDifference) {
calculatingTemperature = 0;
temperatureManager.setPlayerColdProtectionAmount(coldProtection - temperatureDifference);
} else {
calculatingTemperature += temperatureDifference;
temperatureManager.setPlayerColdProtectionAmount(0);
}
}
}
}
I believe that is the simple issue behind the behavior? Just a < where a > was meant to be in the check for considering heatProtection.
