Epic Fight

Epic Fight

13M Downloads

Some modded items have registry names containing illegal characters

Cirion-Spellbinder opened this issue ยท 4 comments

commented

On the Wiki, there is a page titled "Custom Weapon Armor datapack." This page presents a guide on making a datapack to add Epic Fight compatibility to modded weapons and armor, involving creating a series of folders and a json file with the following names:

data -> "modid" -> capabilities -> "type" -> "registrynames".json

where registrynames refers to the registry name of the item which one wants to add compatibility for. However, some modded items have registry names which include illegal characters which cannot be included in file names, for example, "/" occurs in practically all TerraFirmaCraft item names. See, for example, this file from the TerraFirmaCraft source code tagging all the knives added by TerraFirmaCraft as knives.

This means items such as "tfc:metal/knife/steel" cannot be given Epic Fight compatibility through a data pack because "tfc:metal/knife/steel.json" is not a valid file name on account of including two instances of the illegal character "/" in its registry name.

commented

This is latest version issue, with the recommended forge version. This is terrafirmacraft devs comentary about this
image

commented

It is abnormal to contain a slash character in item registry name. There are many other ways to express the item variation like NBT tag or capability. I don't understand why they used that inconvenient way.

commented

image

commented

Fixed on 18.3.7 (1.18.2) and 16.6.3 (1.16.5), Check updates channel in our discord to see how to arrange the folders in order for this to work