Epic Fight

Epic Fight

13M Downloads

[Bug]: custom collider has issues with negative values

D4T4N0TF0UND opened this issue ยท 2 comments

commented

Have you checked if a similar issue is already reported by someone else?

  • I checked there are no similar issues have been reported.

Have you read the support policy?

  • I read it and I accept the policy.

Are you using the latest Epic Fight and recommended Forge version?

  • I checked I'm using latest Epic Fight and recommended Forge version.

Is this issue related to mod incompatibility?

  • This is a mod compatibility issue and I'm aware of the problem.

The mod

No response

Minecraft Version

1.18.2

What happened?

When using a data pack to configure a weapon's collider, failing to use proper decimal points and writing some numbers as integers (EG "center": [0, 0, -0.75]) will prevent the data pack from loading (i assume due to casting/typing issues in java), causing an error message when loading worlds. no issue occurs if [0, 0, 0] is entered and no further testing has been done. The issue is not particularly common but either some clarity in the wiki that the decimal points are required, or some code update to prevent this would be helpful.

steps to reproduce: any data pack modifying weapon colliders with values as specified above causes this issue, as far as I am aware.

commented

this causes the error
image
this does not cause an error
image
this does not cause an error
image

commented

Forgot to mention, using integers in the size attribute also seems to not actually change the size unless the .0 is included