Epic Fight

Epic Fight

13M Downloads

[Bug|Crash] [Cross-Mod] [Visual] : Iron's Spells 'n Spellbooks - Model Placement/clipping issues when casting spells in first person

yoshisman8 opened this issue ยท 6 comments

commented

Have you checked if a similar issue is already reported by someone else?

  • I checked there are no similar issues have been reported.

Have you read the support policy?

  • I read it and I accept the policy.

Are you using the latest Epic Fight and recommended Forge version?

  • I checked I'm using latest Epic Fight and recommended Forge version.

Is this issue related to mod incompatibility?

  • This is a mod compatibility issue and I'm aware of the problem.

The mod

https://github.com/iron431/Irons-Spells-n-Spellbooks

Minecraft Version

1.20.1

What happened?

Preamble: Iron's Spells 'n Spellbooks is open source and linked in the ticket. This should hopefully help make the issue easier to solve.

When casting ISS spells in First Person while in Comabt mode, the player model is pushed 'forward', causing the player's head to now be directly where the camera is. This causes you to be unable to see anything but the inside of your own player's head. I believe the issue could be fixed by culling the head model when casting. Ideally the entire head + helmet should be culled out from the player's first person POV at all times if i'm being honest. Since this issue may crop up with other mods in the future.

commented

This is probably not an issue with epic fight

commented

You need to go to config to modify and disable the first person animation

commented

This is probably not an issue with epic fight

I have dug through both mod's source code to see what could be causing the issue and it kinda all points to it being on EF's side. ISS simply uses Player Animator and Geckolib's methods to animate the player model. But we know that while battle mode is active, the player's model is entirely replaced by Epic Fight's model. Meaning that nothing ISS does should be affecting that model.

I believe the issue lies in an unaddressed incompatibility between Epic Fight and Player Animator/Geckolib. ISS just happens to use Geckolib and Player Animator so it's the catalyst for the issue. It's hard to find the issue without debugging all 3 mods at the same time which i don't have the means to do tho :/

commented

If the issue is due to Player Animator, perhaps EF could simply directly tell Player Animator to cull the player head and hat boxes through Player Animator while in first person to ensure parity? That is worth a shot i think.

commented

If the issue is due to Player Animator, perhaps EF could simply directly tell Player Animator to cull the player head and hat boxes through Player Animator while in first person to ensure parity? That is worth a shot i think.

Actually, you just need to go to the config of the "Iron's Spells 'n Spellbooks" mod and change it, they will be compatible, change "showFirstPersonArms = true" and "showFirstPersonItems = true" to false, and they will be successfully compatible, the cause of this problem may be the problem with the "PlayerAnimator" mod, of course, if you want to keep it"Iron's Spells 'n Spellbooks" first-person casting effect, then I suggest you use the "PlayerEx - Reimagined" mod, which makes both "epic fight" and "Iron's Spells 'n Spellbooks" compatible, including action first-person, and if anyone can make this mod separate "epic fight" and "Iron's Spells". 'n Spellbooks' compatibility is independent, and it couldn't be better, but please forgive me if there are any inaccuracies, as I'm using a translator

commented

I'll look into this more, hopefully we can add compatibility with player animator in the future...