[BUG]: When I was making a dataset, I stumbled upon a critical problem with the giant sword collision box determination!!

Question

[BUG]: When I was making a dataset, I stumbled upon a critical problem with the giant sword collision box determination!!

hyqzaa opened this issue 7 months ago · 14 comments

hyqzaa commented 7 months ago

Have you checked if there's any similar suggestions ?

I checked, there are no similar suggestions that have been reported.

Are you using the latest Epic Fight ?

I checked I'm using latest Epic Fight version.

Is this suggestion related to another mod? (i.e: add animations for X mod)

This is related to other mods.

The mod

Epic Fight

Minecraft Version

1.16.5

What's your suggestion?

When I was making a dataset, I stumbled upon a critical problem with the giant sword collision box determination, which was fatal to the integrated dataset authors![My English is not good, so I can only use translation software to talk——I am an integration package author]1.19.2~1.18.2Only the latest versions of the above two game versions were tested

If the "damage_bonus" value is set to negative for a weapon of the Great Sword type when crafting the packet, then all of your Great Sword type weapons will have a judgment error on part of the attack, while you attack forward the attack animation is correct, but can only attack behind! This is very deadly!! I have tried many cases, and it still exists even after deleting the relevant packets!!! I want to make it disappear, but this is very random, Even if I remove the other irrelevant mods, there are still bugs.

I don't know how to express the qwq order, please do help me, This is my favorite mod...

2024-02-21.23-33-57.mp4

metziupz · Answer 1 · 2024-02-24T16:47:00.000Z

Exactly the same thing is happening to me and I'm on 1.19.2

metziupz · Answer 2 · 2024-02-24T16:50:43.000Z

I just fixed it, it is a temporary solution but it can work until someone fixes it, you simply have to delete the epic fight files in the config folder

MetalKnight56 · Answer 3 · 2024-02-22T22:15:57.000Z

Can you make sure to check if this also happens on 1.19.2 & most importantly in 1.20.1?

hyqzaa · Answer 4 · 2024-02-23T22:59:59.000Z

I tested it all afternoon and found that the bug was firing erratically, and to be honest I'm not sure if it's the result of what I said above. However, by repeatedly comparing the collision box, I found that after the bug triggered, the damage determination of some attacks was similar to slow. For example, when I attack, the animation shows that I hold the sword behind me, the sword's impact box turns red, which should trigger the damage determination, but when the sword is thrown in the middle, the sword's impact box turns back white and cannot cause damage, and when the sword is swung, it turns red again, and this moment the monster hits the red box and causes damage. So far, I have not tested how the bug was triggered. Is there any way to fix the bug manually by modifying the packet? This is really important to me! Thanks for help

MetalKnight56 · Answer 5 · 2024-02-23T23:14:29.000Z

Well i'm not even sure what you are doing to begin with, Why did you want to set the damage bonus to a negative value to begin with? I'm not getting the issue properly nor what's causing it, because i can't really give you a solution without actually knowing the cause of the issue too...

MetalKnight56 · Answer 6 · 2024-02-24T22:30:16.000Z

what files.... and what config folder are you even talking abt?

hyqzaa · Answer 7 · 2024-02-25T15:01:36.000Z

The negative value is set to reduce the damage of some weapons

hyqzaa · Answer 8 · 2024-02-25T15:03:30.000Z

I am an integration package author, how did you fix this bug, my integration package can not continue to produce because of this bug

hyqzaa · Answer 9 · 2024-02-25T15:09:37.000Z

Through the form of packets, such as the Great Sword weapon that comes with the module, I think they are unbalanced, so I lowered the damage in the configuration file, the original damage is 13, then I set the "damage_bonus" value to -6, and the final weapon damage will be 7. I don't know if you understand my approach, but I will try to express it

hyqzaa · Answer 10 · 2024-02-25T15:10:40.000Z

However, if you use unzip software to open the module file and modify some of the files inside, you can do a similar thing

MetalKnight56 · Answer 11 · 2024-02-25T15:44:07.000Z

Yeah and thats exactly what happens right? If you are looking at the tooltip, make sure to update epic fight as in the latest update we fixed an issue with tooltips being unresponsive and not properly displaying the values they should...

hyqzaa · Answer 12 · 2024-02-26T09:45:12.000Z

Using your updated version of the module two days ago, it seems that the strange bug will not appear again, thank you for your efforts

hyqzaa · Answer 13 · 2024-02-26T16:49:12.000Z

After updating the module, although the Great Sword type weapon is solved, the "uchigatana" type that was not bug-free before seems to have a similar bug. However, the good news is that this type of weapon is relatively small, which does not particularly affect the production of integrated packages.

hyqzaa · Answer 14 · 2024-02-26T17:02:14.000Z

After testing other weapons, the "spear" weapon type began to show some similar conditions