Epic Fight

Epic Fight

13M Downloads

[Bug|Crash]: Performing Steel Whirlwind attack crashes the game for other players who witness it.

MakkuSaiko opened this issue · 5 comments

commented

Have you checked if a similar issue is already reported by someone else?

  • I checked there are no similar issues have been reported.

Have you read the support policy?

  • I read it and I accept the policy.

Are you using the latest Epic Fight and recommended Forge version?

  • I checked I'm using latest Epic Fight and recommended Forge version.

Is this issue related to mod incompatibility?

  • This is a mod compatibility issue and I'm aware of the problem.

The mod

No response

Minecraft Version

1.19.2

What happened?

When my brother used a Steel Whirlwind attack, my game crashed. The same happened with other players on our server when they were in close proximity to my brother.
Please see logs below:

Exception Stack Trace.txt
Full Log.log

Unfortunately I did not save the log for server side, but I did check the console when people crashed and It did not show anything that seemed related to the crash (Actually i think it just showed "User Disconnected"). I will attempt to reproduce the error sometime and send the server side log if you need it.

As for a possible fix for the issue: I did change the following in the animations class when tinkering with the code myself:
image
It did fortunately stop the crashing when the skill is used as I tested it with my brother.

commented

This is the result of when I tested Steel Whirlwind on my desktop.

2024-06-23.22-05-04.mp4

Used Epic Fight 19.5.24

If this bug is related to an old random server crash issue (which we called as Thanos bug), Sadly there's nothing I can do for now.

commented

I found the reason. If you assign Steel Whirlwind animation using datapack to weapons that don't have the skill as their innate, the game crashes.

commented

I'll check if the player has Steel Whirlwind. Then it won't create NullPointerException anymore. Thank you for reporting!

commented

Do you happen to have shoulder surfing on your server?

commented

Fixed in 19.5.26. Enjoy it!