Epic Fight

Epic Fight

13M Downloads

[Bug|Crash]: Old datapack compability issue: render mobs as epicfight:custom will make their gear totally invisable

5A93 opened this issue · 11 comments

commented

Please check if a similar issue has already been reported.

  • I checked this type of issue has never been reported.

Please check you're using proper versions.

  • I checked all of them in the right version.

Please check if this issue's from out of our area

  • I understood the problem.

The name of the mod

No response

After all of these, please check if you're just pressing the ok buttons to skip this process.

  • I read the checklist and I promise I'll provide all the information that is needed to fix the issue

Minecraft Version

1.20.1

The Issue

New datapack generation system works pretty fine if you want to use preset. But I can't help noticing that there isn't a good preset for none undead player model mobs, so I gave old datapacks a try. Then I found out old zombie villager rendering didn't really works, and rendering player model will make you crash absolutely, so it goes to epicfight:custom, works in a way that makes mobs looks naked and unarmed.
I think a new tutorial for the new system is urgently needed to make it works more perfectly, videos or pure texts. Myself had encountered so many setback, causing by the reasons I don't know but I'm pretty sure it's the result of I'm not fully understanding how it works, like which parts are crucial and which combination is forbidden so that our saves won't be crashed or unloadable.

Steps to Reproduce

I used old datapack Guard Epic as test subject and example, I slightly adjusted its format to this:
guard.json

commented

Custom renderer is mostly for compatibility. I think the entity you want to patch has some layers which is so hard to be handled by datapack.

Also, we're making tutorial videos for datapack editor but since we're very busy in real life it would take much time to be completed. Please be patience.

commented

Custom renderer is mostly for compatibility. I think the entity you want to patch has some layers which is so hard to be handled by datapack.
Also, we're making tutorial videos for datapack editor but since we're very busy in real life it would take much time to be completed. Please be patience.

Not very possible. It's the guard entity from villager guard, just player models plus vanilla armors and weapons. Maybe it shouldn't be render as custom?

Player and villager have different texture mapping so it will look weird

commented

Custom renderer is mostly for compatibility. I think the entity you want to patch has some layers which is so hard to be handled by datapack.

Also, we're making tutorial videos for datapack editor but since we're very busy in real life it would take much time to be completed. Please be patience.

Not very possible. It's the guard entity from villager guard, just player models plus vanilla armors and weapons. Maybe it shouldn't be render as custom?

commented

Custom renderer is mostly for compatibility. I think the entity you want to patch has some layers which is so hard to be handled by datapack.
Also, we're making tutorial videos for datapack editor but since we're very busy in real life it would take much time to be completed. Please be patience.

Not very possible. It's the guard entity from villager guard, just player models plus vanilla armors and weapons. Maybe it shouldn't be render as custom?

Player and villager have different texture mapping so it will look weird

Mobs themselves works fine, just their gears become invisable. Empty handed mobs don't have any issues for now, maybe I should try to add gears to those mobs' lootable and see what is gonna happen.

commented

Custom renderer is mostly for compatibility. I think the entity you want to patch has some layers which is so hard to be handled by datapack.
Also, we're making tutorial videos for datapack editor but since we're very busy in real life it would take much time to be completed. Please be patience.

Not very possible. It's the guard entity from villager guard, just player models plus vanilla armors and weapons. Maybe it shouldn't be render as custom?

Player and villager have different texture mapping so it will look weird

Tested. It is render as custom makes the gear disappear lol. Render as zombie is fine, but I'm afraid it may cause issues later

commented

BTW rendered custom mobs slide away so fast when dying that beaks all physics XD, which part need to be adjusted to prevent that?

commented

Custom renderer is mostly for compatibility. I think the entity you want to patch has some layers which is so hard to be handled by datapack.
Also, we're making tutorial videos for datapack editor but since we're very busy in real life it would take much time to be completed. Please be patience.

Not very possible. It's the guard entity from villager guard, just player models plus vanilla armors and weapons. Maybe it shouldn't be render as custom?

Player and villager have different texture mapping so it will look weird

I don't really get what he meant, because half of it just looks like salad talk, but from what i understood is that custom patched entities(with imported models, armature and mesh from blender) that can wear armors like the Guard Villager entity, have a lot of trouble rendering the outer layer that renders that armor.

commented

自定义渲染器主要是为了兼容性。我认为您要修补的实体有一些层,这些层很难被数据包处理。
此外,我们正在为数据包编辑器制作教程视频,但由于我们在现实生活中非常忙碌,因此需要很长时间才能完成。请耐心等待。

不太可能。它是来自村民守卫的守卫实体,只是玩家模型加上原版盔甲和武器。也许它不应该被渲染为自定义?

玩家和村民有不同的纹理映射,所以看起来很奇怪

我不太明白他的意思,因为其中有一半看起来只是些花言巧语,但据我了解,自定义修补实体(使用从搅拌机导入的模型、骨架和网格)可以穿戴像守卫村民实体那样的盔甲,但在渲染盔甲的外层时会遇到很多麻烦。

If you don't understand, you can just try it. I had already gave you the file I'm currently using, which had been proven that problem can be solved by changing render to zombie. If your so called "custom patched entities" is more than rendering epicfight:custom, I'm sorry I knew nothing about it.

commented

If you don't understand, you can just try it. I had already gave you the file I'm currently using, which had been proven that problem can be solved by changing render to zombie. If your so called "custom patched entities" is more than rendering epicfight:custom, I'm sorry I knew nothing about it.

what file lol, the guard.json one? Well we use the editor for it now, there's no need to mess with files like that no more. It'll export the datapack as a whole. Custom patched entities, allow users to load in patched models and custom animations from blender into minecraft through a resourcepack packaged with a datapack. I don't know what you are trying to do, it's all confusing, your wording is weird. All i said was that possibly what you were saying was that the custom patched entities i just told you about were having issues rendering an armor layer.

commented

If you don't understand, you can just try it. I had already gave you the file I'm currently using, which had been proven that problem can be solved by changing render to zombie. If your so called "custom patched entities" is more than rendering epicfight:custom, I'm sorry I knew nothing about it.

what file lol, the guard.json one? Well we use the editor for it now, there's no need to mess with files like that no more. It'll export the datapack as a whole. Custom patched entities, allow users to load in patched models and custom animations from blender into minecraft through a resourcepack packaged with a datapack. I don't know what you are trying to do, it's all confusing, your wording is weird. All i said was that possibly what you were saying was that the custom patched entities i just told you about were having issues rendering an armor layer.

Now we knew the best way for rendering player model mobs is still zombie and it's luck for me old datapacks still work before the new tutorial video finally coming to save me. I knew absolutely zero about coding before I tried to mess with minecraft mods' datapacks so I spit tons of garbage words from my noob mouth all the time, sorry for you have to witness these.

commented

Now we knew the best way for rendering player model mobs is still zombie and it's luck for me old datapacks still work before the new tutorial video finally coming to save me. I knew absolutely zero about coding before I tried to mess with minecraft mods' datapacks so I spit tons of garbage words from my noob mouth all the time, sorry for you have to witness these.

There's already 3 videos explaining the main 3 tools of the editors.

https://www.youtube.com/watch?v=iysWR_dSic4 (Weapon type)
https://www.youtube.com/watch?v=GNTgR1YLH5I (Item capability)
https://www.youtube.com/watch?v=bslcU82UoK0 (Asset Importing)