Epic Fight

Epic Fight

18M Downloads

[Suggestion]: Reduce un-needed stacktrace output

Fealtous opened this issue ยท 0 comments

commented

Have you checked if there's any similar suggestions ?

  • I checked, there are no similar suggestions that have been reported.

Are you using the latest Epic Fight ?

  • I checked I'm using latest Epic Fight version.

Is this suggestion related to another mod? (i.e: add animations for X mod)

  • This is related to other mods.

The mod

No response

Minecraft Version

1.20.1

What's your suggestion?

Appreciate the effort to have robust logging, however printing the stack trace here and here only results in bloated logs when other mods are involved which do not have the caps epicfight is looking for.

I think it's fine if you want to add a Logutils.getLogger().warn(...) indicating the registry item which doesn't have the cap, but the stack trace is just un-necessary as it gets reprinted over and over and over...
For example, this log https://mclo.gs/7ghxZNS, contains over 1.83MB of just this un-needed logging, eventually hitting mclo.gs line limit before reaching the actual error which was unrelated to epic fight.

If you'd like, I can PR a more compact logging solution.